search

MarginallyClever / Makelangelo-software

Software for plotters - especially the wall-hanging polargraph also called Makelangelo.
http://www.marginallyclever.com/
GNU General Public License v2.0
351 stars 177 forks source link

7.8.3 doesn't save width settings for custom machine #212

Closed tjhawkey closed 7 years ago

tjhawkey commented 7 years ago

This did work in 7.8.1. About to test 7.9.0

i-make-robots commented 7 years ago

thank you!

On Fri, Nov 4, 2016 at 5:34 PM, tjhawkey notifications@github.com wrote:

This did work in 7.8.1. About to test 7.9.0

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MarginallyClever/Makelangelo-software/issues/212, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZYhp4eG7UccegBVWnpwzDkW6oYdKdKks5q688mgaJpZM4KqHIJ .

Dan Royer, Owner, Marginally Clever Robots https://www.marginallyclever.com/ Ph: +1 (604) 259-9564 Mo: +1 (604) 916-2281

i-make-robots commented 7 years ago

Can you write a java unit test that would confirm this always works?

On Fri, Nov 4, 2016 at 5:43 PM, Dan Royer dan@marginallyclever.com wrote:

thank you!

On Fri, Nov 4, 2016 at 5:34 PM, tjhawkey notifications@github.com wrote:

This did work in 7.8.1. About to test 7.9.0

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MarginallyClever/Makelangelo-software/issues/212, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZYhp4eG7UccegBVWnpwzDkW6oYdKdKks5q688mgaJpZM4KqHIJ .

Dan Royer, Owner, Marginally Clever Robots https://www.marginallyclever.com/ Ph: +1 (604) 259-9564 Mo: +1 (604) 916-2281

Dan Royer, Owner, Marginally Clever Robots https://www.marginallyclever.com/ Ph: +1 (604) 259-9564 Mo: +1 (604) 916-2281

tjhawkey commented 7 years ago

Doesn't save settings in 7.9.0 for custom machine, 2+ or 3+. Always wants to be 914.4 mm wide and 1219 tall. Makelangelo 5 is un-adjustable 650 x 1000.

Sorry, I'm not clear on what kind of java test you need. My wife is the programmer. :)

i-make-robots commented 7 years ago

M5 should be. 2 and 3 should be adjustable. There should be a unit test to keep this from breaking.

On Nov 4, 2016, at 5:49 PM, tjhawkey notifications@github.com wrote:

Doesn't save settings in 7.9.0 for custom machine, 2+ or 3+. Always wants to be 914.4 mm wide and 1219 tall. Makelangelo 5 is un-adjustable 650 x 1000.

Sorry, I'm not clear on what kind of java test you need. My wife is the programmer. :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

i-make-robots commented 7 years ago

There is a patch in the master branch on commit da043ee3b291b6b2c56159d13aa3db9249913b6b. Can you test it and see if that helps?

tjhawkey commented 7 years ago

Yes. Thanks!

⁣From my phone

Sent from BlueMail

​

On Nov 5, 2016, 7:20 PM, at 7:20 PM, Dan Royer notifications@github.com wrote:

There is a patch in the master branch. Can you test it and see if that helps?

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/MarginallyClever/Makelangelo-software/issues/212#issuecomment-258648924

tjhawkey commented 7 years ago

Hi Dan, I am still working on learning how to make a jar for myself.If you send me one, I can do the test right away. The new features look great and I'm excited to try them once I can put the size in.Thanks,Tim   On 11/05/16, Dan Royernotifications@github.com wrote: There is a patch in the master branch. Can you test it and see if that helps?—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

i-make-robots commented 7 years ago

Can you follow the github wiki steps? Once you have eclipse set up click the green big to run.

On Nov 9, 2016, at 7:05 PM, tjhawkey notifications@github.com wrote:

Hi Dan, I am still working on learning how to make a jar for myself.If you send me one, I can do the test right away. The new features look great and I'm excited to try them once I can put the size in.Thanks,Tim On 11/05/16, Dan Royernotifications@github.com wrote: There is a patch in the master branch. Can you test it and see if that helps?—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

i-make-robots commented 7 years ago

@tjhawkey any news?

tjhawkey commented 7 years ago

Hi Dan, I plan to test this weekend. Thanks!

⁣From my phone

Sent from BlueMail

​

On Nov 11, 2016, 12:39 PM, at 12:39 PM, Dan Royer notifications@github.com wrote:

@tjhawkey any news?

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/MarginallyClever/Makelangelo-software/issues/212#issuecomment-260011947

turaluralu commented 7 years ago

Hi Dan, I have had the same Problem saving the settings. Build it from scratch (masterbranch) . Now it works. Thanks a lot, J.

turaluralu commented 7 years ago

Hi again, aarrrghh now I can´t save custom paper settings. Another thing is that all settings can only be saved when the last change is the Paper setting to anything (exept custom) j.

i-make-robots commented 7 years ago

please list the steps you're taking so i can repeat them and see the effect.

On Tue, Nov 22, 2016 at 2:06 PM, turaluralu notifications@github.com wrote:

Hi again, aarrrghh now I can´t save custom paper settings. Another thing is that all settings can only be saved when the last change is the Paper setting to anything (exept custom) j.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MarginallyClever/Makelangelo-software/issues/212#issuecomment-262379988, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZYhnTL-5BaPNzzT2J2za0Ad-BBRA_rks5rA2dPgaJpZM4KqHIJ .

Dan Royer, Owner, Marginally Clever Robots https://www.marginallyclever.com/ Ph: +1 (604) 259-9564 Mo: +1 (604) 916-2281

tjhawkey commented 7 years ago

Hi Dan, I had previously set the machine size in 7.8.3 for custom machine. No problem.7.9.0 has (as you know) options for 2+, 3+, 5+, and custom.It remembers paper color, and paper size (and I think everything else on those two tabs), but won't retain machine size.I can set it and save it, but when I go back, they are still the default values, 914.4 and 1219.2Pulley size and direction are retained properly.Thanks, I'm having great fun drawing pictures of my family.Tim 

tjhawkey commented 7 years ago

Also, I haven't sees any evidence of the other behavior relating to the order of changes. Tim 

i-make-robots commented 7 years ago

and you're building from the dev branch? I thought I fixed this bug two weeks ago.

On Tue, Nov 22, 2016 at 6:21 PM, tjhawkey notifications@github.com wrote:

Also, I haven't sees any evidence of the other behavior relating to the order of changes. Tim On 11/22/16, Dan Royernotifications@github.com wrote: please list the steps you're taking so i can repeat them and see the effect.On Tue, Nov 22, 2016 at 2:06 PM, turaluralu < notifications@github.com>wrote:> Hi again,> aarrrghh now I can´t save custom paper settings.> Another thing is that all settings can only be saved when the last change> is the Paper setting to anything (exept custom)> j.>> —> You are receiving this because you commented.> Reply to this email directly, view it on GitHub> https://github.com/ MarginallyClever/Makelangelo-software/issues/212#issuecomment-262379988,> or mute the thread> https://github.com/notifications/unsubscribe- auth/ABZYhnTL-5BaPNzzT2J2za0Ad-BBRA_rks5rA2dPgaJpZM4KqHIJ> .>-- Dan Royer, Owner, Marginally Clever Robotshttps://www.marginallyclever.com/Ph: +1 (604) 259-9564Mo: +1 (604) 916-2281—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MarginallyClever/Makelangelo-software/issues/212#issuecomment-262421253, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZYhkX56xpaSJ1YLp3l66zsm5Tf6RaMks5rA6MugaJpZM4KqHIJ .

Dan Royer, Owner, Marginally Clever Robots https://www.marginallyclever.com/ Ph: +1 (604) 259-9564 Mo: +1 (604) 916-2281

tjhawkey commented 7 years ago

You are right (I hope).  I haven't had time to build yet (sorry).  I coach a FIRST Lego League team and we're getting ready for our tournament.Tim  

i-make-robots commented 7 years ago

I make robots and I'm getting ready for Black Friday while filling back orders. The gift of success!

On Tue, Nov 22, 2016 at 6:45 PM, tjhawkey notifications@github.com wrote:

You are right (I hope). I haven't had time to build yet (sorry). I coach a FIRST Lego League team and we're getting ready for our tournament.Tim

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MarginallyClever/Makelangelo-software/issues/212#issuecomment-262423633, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZYhpm5QMy3bA9hVkNd41KEGOYYTXuOks5rA6jGgaJpZM4KqHIJ .

Dan Royer, Owner, Marginally Clever Robots https://www.marginallyclever.com/ Ph: +1 (604) 259-9564 Mo: +1 (604) 916-2281

turaluralu commented 7 years ago

Hi Dan, you : please list the steps you're taking so i can repeat them and see the effect. settings, changes Paper Size to custom 420 x 560, save . If i klick settings again the Paper Size has not changed. Same thing at any other settings. But here I can work around if the last step is changing Paper Size to what ever (except custom) than all the other Settings are saved too.

You: and you're building from the dev branch? I thought I fixed this bug two weeks ago.

Builded main Branch. not dev branch. Maby that´s the Problem. I´ll try.....

turaluralu commented 7 years ago

Hi, build from dev branch is not good for me. No settings can be saved :-( So I´ll build it from master branch again and try to put my DIN A2 Paper (420x560) in PanelAdjustPaper.java and compile again. It´s a workaround I kow but maby it works for me.

i-make-robots commented 7 years ago

I tried your steps, paper size settings are saving for me.

On Wed, Nov 23, 2016 at 7:48 AM, turaluralu notifications@github.com wrote:

Hi, build from dev branch is not good for me. No settings can be saved :-( So I´ll build it from master branch again and try to put my DIN A2 Paper (420x560) in PanelAdjustPaper.java and compile again. It´s a workaround I kow but maby it works for me.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MarginallyClever/Makelangelo-software/issues/212#issuecomment-262552236, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZYhqNIZa80e6wdx6ArvEQ5lkY6jhrsks5rBGBbgaJpZM4KqHIJ .

Dan Royer, Owner, Marginally Clever Robots https://www.marginallyclever.com/ Ph: +1 (604) 259-9564 Mo: +1 (604) 916-2281

turaluralu commented 7 years ago

hmm, maybe it's a problem regarding my german keyboardlayout.
How ever. The workaround, modifying the PanelAdjustPaper.java works fine and I´m happy. Thanks for your help, J.

i-make-robots commented 7 years ago

german keyboard shouldn't make a difference. are you typing comma "," instead of period "." for decimals? I thought I took care of that....

On Wed, Nov 23, 2016 at 10:30 AM, turaluralu notifications@github.com wrote:

hmm, maybe it's a problem regarding my german keyboardlayout. How ever. The workaround, modifying the PanelAdjustPaper.java works fine and I´m happy. Thanks for your help, J.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MarginallyClever/Makelangelo-software/issues/212#issuecomment-262595611, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZYhrl76fVFYTC8ZqXyhKZao6G6Rxvyks5rBIZSgaJpZM4KqHIJ .

Dan Royer, Owner, Marginally Clever Robots https://www.marginallyclever.com/ Ph: +1 (604) 259-9564 Mo: +1 (604) 916-2281

turaluralu commented 7 years ago

tried both and without decimal separator. But saving isn´t possible.

i-make-robots commented 7 years ago

Is this issue still ongoing?

tjhawkey commented 7 years ago

Hi Dan, I think the non-saving is resolved. At least the software on the machine saves it, though I haven't tested it with my custom makelangelo yet. I will try with the hardware later this week. Thanks

On Sat, Jul 29, 2017 at 11:27 PM, Dan Royer notifications@github.com wrote:

Is this issue still ongoing?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://mailtrack.io/trace/link/a1748812a1655432c7a206ba4d74d99863799d4e?url=https%3A%2F%2Fgithub.com%2FMarginallyClever%2FMakelangelo-software%2Fissues%2F212%23issuecomment-318875475&userId=1910608&signature=92a9ab516aefdd59, or mute the thread https://mailtrack.io/trace/link/e812db053a04d3d371708c004608a82735040c96?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARvWQr8o1W5uLONUP-gxPcaNtIEWPSWkks5sS_gngaJpZM4KqHIJ&userId=1910608&signature=b4f1c3476f14ffbf .

Ianmcmill commented 5 years ago

On 7.20.0 upon disconnecting the custom settings will get discarded and custom settings revert back to 650 width and 1000 height.

i-make-robots commented 5 years ago

Is this makelangelo #0? If it has a custom of number then it will remember.

On Apr 25, 2019, at 2:09 PM, Ianmcmill notifications@github.com wrote:

On 7.20.0 upon disconnecting the custom settings will get discarded and custom settings revert back to 650 width and 1000 height.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

i-make-robots commented 5 years ago

Edit: SHOULD remember.

On Apr 25, 2019, at 2:15 PM, Dan Royer dan@marginallyclever.com wrote:

Is this makelangelo #0? If it has a custom of number then it will remember.

On Apr 25, 2019, at 2:09 PM, Ianmcmill notifications@github.com wrote:

On 7.20.0 upon disconnecting the custom settings will get discarded and custom settings revert back to 650 width and 1000 height.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

Ianmcmill commented 5 years ago

Yeah it does now somehow. Don't know why it didn't earlier. Maybe a java thing or my fault.

Oh wait. It just did forget the settings again. What happened was that after I started the gcode nothing happened. I disconnected and reconnected and the settings under customs were gone. I cannot reproduce this procedure somehow. Maybe I just need to get used to the machine.