MarginallyClever / Makelangelo-software

Software for plotters - especially the wall-hanging polargraph also called Makelangelo.
http://www.marginallyclever.com/
GNU General Public License v2.0
350 stars 177 forks source link

Custom machine hardware settings are not being saved. #312

Closed i-make-robots closed 3 years ago

i-make-robots commented 3 years ago

Describe the bug Hardware settings in firmware EEPROM should be changed as little as possible. Settings should be applied once and left there. @gsohler reports custom makelangelo 3s are resetting limits and home position, and on machine start they have to be rechecked every time.

To Reproduce Steps to reproduce the behavior:

  1. install makelangelo firmware on arduino board
  2. connect to software.
  3. apply limits and home settings.
  4. disconnect robot
  5. restart software.
  6. reconnect and check settings. numbers have changed.

Expected behavior settings should not change between boots.

Screenshots If applicable, add screenshots to help explain your problem.

Platform (please complete the following information):

Additional context see also https://github.com/MarginallyClever/Makelangelo-software/pull/311

gsohler commented 3 years ago

Hi Just to clarify: I am author of #311, not #312. I use D11 command manyally to make sure, that the belt len is saved in the machine.

i-make-robots commented 3 years ago

@gsohler are you still seeing this issue?

gsohler commented 3 years ago

I have now connected Makelangelo to my serial terminal and typed D8 to get the belt lengths, and they were correct without defining them. So it appears they are saved in flash. Still i feel better that they are set everytime by software(which does happen) . I Dont like to find out a picture looks squeezed just because the belt lengths are wrong by chance.

So to answer your question: No I dont see the issue (anymore). I did never see a squeezed plot(after i managed to get the microsteps correct) Still i feel that i very much want to the belt length to be defined by software. If i unscrew the motors from my plotter and put them onto a wall, i dont want to miss defining the belt lenght(Width and height is obvious)

Guenther

i-make-robots commented 3 years ago

imho belt length should almost never be set by software. it should be remembered in the machine's EEPROM. that way a software mistake cannot screw it up. In the latest firmware master branch, belt length can be adjusted in the LCD panel "Settings" menu.