Infinite loop at the end of the drawing

MarginallyClever / Makelangelo-software

Software for plotters - especially the wall-hanging polargraph also called Makelangelo.

http://www.marginallyclever.com/

GNU General Public License v2.0

349 stars 165 forks source link

Infinite loop at the end of the drawing #658

Closed coliss86 closed 2 years ago

coliss86 commented 2 years ago

Steps to make the bug happen

Setup an end gcode
Draw a picture

What happened At the end of the drawing, the app is stuck in a infinite loop with the robot while sending over and over the same line. If I click on "Emergency Stop", it stops. The marlin logs shows the following:

; Park position is in the end user gcode.

Platform (please complete the following information):

Version: master
OS: macos
Robot model (if any): custom

PPAC37 commented 2 years ago

Hi, it seems to me that comments are not removed in the current implementation for start and end user g-code. However, in principle, the comments should not be sent to the marlin firmware (the firmware does not have the role of filtering them (Except when reading a .gcode file) because in the idea the serial connection is slow, so need just the necessary ... )

coliss86 commented 2 years ago

Fixed in #658, thanks !