search

MarginallyClever / Robot-Overlord-App

Simulation and control software for robots
https://www.marginallyclever.com/
GNU General Public License v2.0
168 stars 49 forks source link

Allow deferred evaluation of parameters during arm editing. #134

Closed Jackymancs4 closed 1 year ago

Jackymancs4 commented 1 year ago

Is your feature request related to a problem? Please describe. As per discussion on Discord. Editing any value in the arm editor cause it to be instantly evaluated. This can result in an unexpected behavior (like the arm exploding) which is difficult to undo.

Describe the solution you'd like "Save" or "Cancel" in the arm editor. Evaluate the parameters on on save. Please allow Reset or Undo.

Describe alternatives you've considered robotComponent needs an "on/off" switch. now do i make PowerSwitchComponent or do i make it a part of RobotComponent...

Additional context The body of the issue should be edited to include proper details.

i-make-robots commented 1 year ago

If instant evaluation doesn't happen then how do you know what you changed and if the change is correct? I think making the undo/redo work with the edit panel is the better way to go.

i-make-robots commented 1 year ago

in branch motor-1, I set the "all meshes at root origin" selected from the start.
most parameters now seem undo-able. Also split "show DH" to be per-joint.

i-make-robots commented 1 year ago

https://github.com/MarginallyClever/Robot-Overlord-App/tree/motor-1 much improved support for undo/redo.

i-make-robots commented 1 year ago

Merged into main. @Jackymancs4 please let me know if this meets your needs. also updated instructions for how to build + publish an arm. https://github.com/MarginallyClever/Robot-Overlord-App/wiki/How-to-add-a-new-robot-arm