Mari0-CE / Mari0-Community-Edition

A community-driven effort to fix and polish the latest version of Mari0:SE
Do What The F*ck You Want To Public License
60 stars 17 forks source link

[Optimization] Use love.graphics.scale() instead of multiplying everything by scale #28

Open skysometric opened 6 years ago

skysometric commented 6 years ago

Besides requiring fewer mathematical operations across the board, this will also make it easier to add new features without having to work with complicated draw logic.

This is a big project since it's such a prevalent part of the code, so it may not be a good idea until a lot of the cool new features are in.

HugoBDesigner commented 6 years ago

To be perfectly fair, most of the drawing code is messed up. To implement a new item in the pause menu, I had to reorganize all of the items in the entire menu, because they're not programmed with new implementations in mind. That said, most of SE's code seem to take on this "works just as-is" approach, so implementing something like this would mean basically rewriting the entire game. I'll definitely consider it, but don't hold your hopes too high :/