search

Mari023 / AE2WirelessTerminalLibrary

port of https://github.com/p455w0rd/AE2WirelessTerminalLibrary for fabric
MIT License
9 stars 26 forks source link

Feature Request: Ability to change ingredient (and output) amount on processing patterns in wireless pattern encoding terminal #300

Closed Meryl closed 2 months ago

Meryl commented 2 months ago

The vanilla pattern encoding terminal allows you to change amounts in a processing recipe by middle clicking the slot (either one of the input slots or an output slot). This feature would be really nice to have on the wireless version as well.

Mari023 commented 2 months ago

the wireless pattern encoding terminal uses the same code as the pattern encoding terminal, this should work

Meryl commented 2 months ago

TLDR: This doesn't work in the (Universal) Wireless Terminal due to a conflict with a bound middle click for Inventory Tweaks Renewed. It does work for the regular pattern encoding terminal, so it's weird that it would conflict for one but not the other.

The part of the post I mostly typed up before I found the cause:

Here are the versions I'm running (part of ATM9TTS):

Mod version
Applied Energistics 2 15.2.11
AE2 Wireless Terminal Library 1.3.0
Inventory Tweaks Renewed 1.1.0

There's also a bunch of AE add-ons etc., here's the ones I could find:

Mod version
AE2 Things 1.2.1
AE2 Insert Export Card 1.3.0
AECapFix 0.9
Applied Botanics 1.5.0
AppliedE 0.14.0
AppliedFlux 1.1.8
Applied Mekanistics 1.4.2
ExtendedAE 1.1.11

It does indeed hint that it should be possible: image (the amount of 4 in this screenshot is because I had 4 of the item on my cursor when I clicked the ingredient slot)

I just checked key binding conflicts, and it turns out that Inventory Tweaks Renewed has the option "Sort Inventory Under Cursor" which is conflicting for the (Universal?) Wireless Terminal only.

Mari023 commented 2 months ago

ah, either ae2 or Inventory Tweaks Renewed has something to fix the conflict for the pattern access terminal, but not for the wireless one I'll look into it

Mari023 commented 2 months ago

you can disable the screen in the Inventory Tweaks Renewed config

you can duplicate these lines

        [[sorting.containerOverrides]]
                containerClass = "de.mari_023.ae2wtlib.wct.*Screen"
                sortRange = ""

and change "de.mari_023.ae2wtlib.wct.*Screen" to "de.mari_023.ae2wtlib.wet.*Screen" (c -> e in wct)

I will make a PR soon to fix it by default

(note for myself: https://github.com/JDKDigital/InvTweaksRefoxed/blob/dev-1.21.0/src/main/java/invtweaks/config/InvTweaksConfig.java)

Meryl commented 2 months ago

That's great, thanks!