mlhale7
commented
11 months ago @hilaryhavens - I think it's okay to keep the template as is, but all those encoding should remember to remove the element if we can't enter a date. The intention with having a date like 1111-01-01 is that those encoding will clearly see that this date should be edited or removed but that it will validate regardless (and make the required formatting for validation obvious). I'm definitely open to other strategies to making the template easier to fill out correctly if any have suggestions. Others should feel free to comment on this topic. If I receive feedback, I'll open a separate PR (since no changes were made to the template in this PR).
Related Issue - 23
What does this Pull Request do?
In our weekly RA meeting, the question came up of what to do with @when within the date element when the date is unknown. In the template the @when value had been put in as 1111-01-01 for validation purposes. In our existing XML for letters within unknown dates, this placeholder value had been left without editing. This PR removes the entire date element (including @when) if the date is unknown.
How should this be tested?
Check to see if:
<date>Unknown</date>etc.)Additional Notes
A few changes were made that did not involve removing the date element. In particular,
Edgeworth_Harvard_604762_unknown.xmlwas renamed toEdgeworth_Harvard_604762_1848_12_28.xmlas it had a date to include. Within GitHub this change appears as deleting the original file and adding a completely new one.I also changed the wrapping for date for
Edgeworth_Iowa_0001_1844-12.xmlas it didn't include the text values within it.If you have questions or concerns about any changes present in the commit, please comment. I'm including everyone for informational purposes (but only one approval is needed).