hilaryhavens
commented
7 months ago Thanks for flagging this, Meredith! In both cases, I would move the [<figure>](https://www.tei-c.org/release/doc/tei-p5-doc/en/html/ref-figure.html) should only enclose the figure description and not the text related to it so we know precisely where to place it? On that assumption, I have moved also the closing
#1
aldermen<lb/>
glyphic <hi rend="underline">frights </hi> <figure></figDesc>three figures, in a kneeling posture, drawn facing away from a figure of Osiris</figDesc> all pointing with<lb/>Should be:
aldermen <figure></figDesc>two figures, in a kneeling posture, drawn facing away from a figure of Osiris, with two flourishes beneath</figDesc></figure> embossed gold <choice><orig>hiero<lb/>
glyphic</orig><reg>hieroglyphic</reg></choice> <hi rend="underline">frights</hi> all pointing with<lb/>#2
a heavy stair <figure><figDesc>a woman holding up twelve candle branches with a small square base</figDesc>case while her feet stand on a globe so<lb/>
small that it never could support her & it seems al-<lb/>
ways stepping from under her - A candalabra figure<lb/>
<add>in the dining room</add><lb/>
with arms painfully holding 12 candle branches<lb/>
heavier & larger than herself and without a resting<lb/>
place for her poor feet - on the contrary with<lb/>
a cruel gold basket hung on her ancles ! - </figure><lb/>Should be:
a heavy stair case while her feet stand on a globe so<lb/>
small that it never could support her & it seems <choice><orig>al-<lb/>
ways</orig><reg>always</reg></choice> stepping from under her - <add>also a slice of a bronze</add><del>A</del> candalabra figure<lb/>
<add>in the dining room</add><lb/>
with <figure><figDesc>a woman holding up twelve candle branches with a small square base</figDesc></figure> arms painfully holding 12 candle branches<lb/>
heavier & larger than herself and without a resting<lb/>Thanks and will look forward to discussing this further on Thursday, if necessary!
mlhale7
elizawilcox
rrunia
What does this Pull Request do?
This PR addresses the requested changes outlined in issue #34
How should this be tested?
Ensure that the change made to the text within editorialDecl matches expectations and that this change has been made across all XML files.
Additional changes had to be made to make all existing XML files validate. Please take a special look at Edgeworth_Bodleian_696_1819_14_17.xml. This letter had two figureDesc tags that were moved by me and might potentially not be situated as needed. I've attached the scans below. We can potentially discuss this more in our RA meeting instead and make changes after this PR is closed.
Additional notes
Try to avoid copying and pasting the ref values for persName and placeName. There were several instances in which a ref value went to the Personography, but a place was referenced. There are likely more that I didn't catch since this mistake doesn't cause a validation error. Please also always remember to add a file extension (.xml).