VS2012 build warnings

[GoogleCodeExporter]

vs2012 builds, but there are warnings.  See below.
Some projects treat warnings as errors (/WX), so would be good to clean up when 
possible.

How to build:
get source
git clone http://git.chromium.org/webm/libvpx.git
cd libvpx
git checkout master

use msys (or cycwin?) shell:

mkdir win64
cd win64
../libvpx/configure --target=x86_64-win64-vs9 --enable-static-msvcrt 
--disable-install-docs
devenv.com vpx.sln -upgrade
make -i V=1
devenv.com vpx.sln -upgrade

3>Time Elapsed 00:00:56.30
4>------ Build started: Project: decode_to_md5, Configuration: Release x64 -----
-
5>------ Build started: Project: decode_with_drops, Configuration: Release x64 -
-----
6>------ Build started: Project: error_resilient, Configuration: Release x64 ---

---
7>------ Build started: Project: force_keyframe, Configuration: Release x64 ----
--
8>------ Build started: Project: postproc, Configuration: Release x64 ------
9>------ Build started: Project: simple_decoder, Configuration: Release x64 ----
--
10>------ Build started: Project: simple_encoder, Configuration: Release x64 ---

---
11>------ Build started: Project: test_libvpx, Configuration: Release x64 ------

12>------ Build started: Project: twopass_encoder, Configuration: Release x64 --
----
5>Build started 1/17/2013 7:02:54 PM.
13>------ Build started: Project: vp8_scalable_patterns, Configuration: Release
x64 ------
14>------ Build started: Project: vp8_set_maps, Configuration: Release x64 -----
-
4>Build started 1/17/2013 7:02:54 PM.
15>------ Build started: Project: vp8cx_set_ref, Configuration: Release x64 ----
--
16>------ Build started: Project: vpxdec, Configuration: Release x64 ------
17>------ Build started: Project: vpxenc, Configuration: Release x64 ------
7>Build started 1/17/2013 7:02:54 PM.
11>Build started 1/17/2013 7:02:54 PM.
14>Build started 1/17/2013 7:02:54 PM.
16>Build started 1/17/2013 7:02:54 PM.
6>Build started 1/17/2013 7:02:54 PM.
10>Build started 1/17/2013 7:02:54 PM.
8>Build started 1/17/2013 7:02:54 PM.
12>Build started 1/17/2013 7:02:54 PM.
9>Build started 1/17/2013 7:02:54 PM.
4>ClCompile:
4>  md5_utils.c
14>ClCompile:
14>  vp8_set_maps.c
7>ClCompile:
7>  force_keyframe.c
13>Build started 1/17/2013 7:02:54 PM.
5>ClCompile:
5>  decode_with_drops.c
17>Build started 1/17/2013 7:02:54 PM.
16>ClCompile:
16>  md5_utils.c
15>Build started 1/17/2013 7:02:54 PM.
14>vp8_set_maps.c(117): warning C4267: 'function' : conversion from 'size_t' to
'unsigned int', possible loss of data
14>vp8_set_maps.c(205): warning C4018: '<' : signed/unsigned mismatch
14>vp8_set_maps.c(221): warning C4018: '<' : signed/unsigned mismatch
7>force_keyframe.c(109): warning C4267: 'function' : conversion from 'size_t' to
 'unsigned int', possible loss of data
10>ClCompile:
10>  simple_encoder.c
6>ClCompile:
6>  error_resilient.c
11>ClCompile:
11>  test_libvpx.cc
8>ClCompile:
8>  postproc.c
12>ClCompile:
12>  twopass_encoder.c
9>ClCompile:
9>  simple_decoder.c
6>error_resilient.c(109): warning C4267: 'function' : conversion from 'size_t' t
o 'unsigned int', possible loss of data
10>simple_encoder.c(119): warning C4267: 'function' : conversion from 'size_t' t
o 'unsigned int', possible loss of data
15>ClCompile:
15>  vp8cx_set_ref.c
13>ClCompile:
13>  vp8_scalable_patterns.c
17>ClCompile:
17>  args.c
12>twopass_encoder.c(110): warning C4267: 'function' : conversion from 'size_t'
to 'unsigned int', possible loss of data
15>vp8cx_set_ref.c(114): warning C4267: 'function' : conversion from 'size_t' to
 'unsigned int', possible loss of data
13>vp8_scalable_patterns.c(110): warning C4267: 'function' : conversion from 'si
ze_t' to 'unsigned int', possible loss of data
13>vp8_scalable_patterns.c(122): warning C4101: 'file_hdr' : unreferenced local
variable
13>vp8_scalable_patterns.c(123): warning C4101: 'frame_hdr' : unreferenced local
 variable
4>  decode_to_md5.c
16>  args.c
17>  y4minput.c
16>  tools_common.c
16>  halloc.c
16>..\libvpx\nestegg\halloc\src\halloc.c(87): warning C4146: unary minus operato
r applied to unsigned type, result still unsigned
16>..\libvpx\nestegg\halloc\src\halloc.c(122): warning C4146: unary minus operat
or applied to unsigned type, result still unsigned
16>..\libvpx\nestegg\halloc\src\halloc.c(131): warning C4146: unary minus operat
or applied to unsigned type, result still unsigned
16>..\libvpx\nestegg\halloc\src\halloc.c(228): warning C4146: unary minus operat
or applied to unsigned type, result still unsigned
16>..\libvpx\nestegg\halloc\src\halloc.c(249): warning C4146: unary minus operat
or applied to unsigned type, result still unsigned
10>Link:
13>Link:
13>  vp8_scalable_patterns.vcxproj -> c:\on2\win64\x64\Release\vp8_scalable_patt
erns.exe
10>  simple_encoder.vcxproj -> c:\on2\win64\x64\Release\simple_encoder.exe
14>Link:
12>Link:
12>  twopass_encoder.vcxproj -> c:\on2\win64\x64\Release\twopass_encoder.exe
14>  vp8_set_maps.vcxproj -> c:\on2\win64\x64\Release\vp8_set_maps.exe
6>Link:
6>  error_resilient.vcxproj -> c:\on2\win64\x64\Release\error_resilient.exe
8>Link:
9>Link:
9>  simple_decoder.vcxproj -> c:\on2\win64\x64\Release\simple_decoder.exe
8>  postproc.vcxproj -> c:\on2\win64\x64\Release\postproc.exe
4>Link:
4>  decode_to_md5.vcxproj -> c:\on2\win64\x64\Release\decode_to_md5.exe
15>Link:
15>  vp8cx_set_ref.vcxproj -> c:\on2\win64\x64\Release\vp8cx_set_ref.exe
5>Link:
5>  decode_with_drops.vcxproj -> c:\on2\win64\x64\Release\decode_with_drops.exe
7>Link:
7>  force_keyframe.vcxproj -> c:\on2\win64\x64\Release\force_keyframe.exe
5>
5>Build succeeded.
5>
5>Time Elapsed 00:00:00.70
12>
12>Build succeeded.
12>
12>Time Elapsed 00:00:00.48
8>
8>Build succeeded.
8>
8>Time Elapsed 00:00:00.50
4>
4>Build succeeded.
4>
4>Time Elapsed 00:00:00.71
13>
13>Build succeeded.
13>
13>Time Elapsed 00:00:00.47
9>
9>Build succeeded.
9>
9>Time Elapsed 00:00:00.50
15>
15>Build succeeded.
15>
15>Time Elapsed 00:00:00.45
14>
14>Build succeeded.
14>
14>Time Elapsed 00:00:00.57
6>
6>Build succeeded.
6>
6>Time Elapsed 00:00:00.52
7>
7>Build succeeded.
7>
7>Time Elapsed 00:00:00.57
10>
10>Build succeeded.
10>
10>Time Elapsed 00:00:00.52
16>  nestegg.c
17>  tools_common.c
17>  EbmlWriter.c
16>  vpxdec.c
17>  vpxenc.c
16>..\libvpx\vpxdec.c(55): warning C4114: same type qualifier used more than onc
e
17>..\libvpx\vpxenc.c(95): warning C4114: same type qualifier used more than onc
e
17>..\libvpx\vpxenc.c(96): warning C4114: same type qualifier used more than onc
e
17>..\libvpx\vpxenc.c(1455): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(1456): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(1458): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(1459): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(1475): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(1478): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(1479): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(1495): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(1498): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(1499): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(1525): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(1530): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(1535): warning C4018: '<' : signed/unsigned mismatch
17>..\libvpx\vpxenc.c(2288): warning C4267: 'function' : conversion from 'size_t
' to 'unsigned int', possible loss of data
11>  altref_test.cc
16>Link:
16>  vpxdec.vcxproj -> c:\on2\win64\x64\Release\vpxdec.exe
16>
16>Build succeeded.
16>
16>Time Elapsed 00:00:01.22
17>Link:
17>  vpxenc.vcxproj -> c:\on2\win64\x64\Release\vpxenc.exe
17>
17>Build succeeded.
17>
17>Time Elapsed 00:00:01.32
11>..\libvpx\test/i420_video_source.h(52): warning C4800: 'FILE *' : forcing val
ue to bool 'true' or 'false' (performance warning)
11>..\libvpx\test/i420_video_source.h(55): warning C4267: 'argument' : conversio
n from 'size_t' to 'long', possible loss of data
11>  config_test.cc
11>  cq_test.cc
11>..\libvpx\test/i420_video_source.h(52): warning C4800: 'FILE *' : forcing val
ue to bool 'true' or 'false' (performance warning)
11>..\libvpx\test/i420_video_source.h(55): warning C4267: 'argument' : conversio
n from 'size_t' to 'long', possible loss of data
11>..\libvpx\test\cq_test.cc(60): warning C4267: '+=' : conversion from 'size_t'
 to 'int', possible loss of data
11>  datarate_test.cc
11>..\libvpx\test/i420_video_source.h(52): warning C4800: 'FILE *' : forcing val
ue to bool 'true' or 'false' (performance warning)
11>..\libvpx\test/i420_video_source.h(55): warning C4267: 'argument' : conversio
n from 'size_t' to 'long', possible loss of data
11>..\libvpx\test\datarate_test.cc(57): warning C4244: '+=' : conversion from 'd
ouble' to 'int', possible loss of data
11>..\libvpx\test\datarate_test.cc(70): warning C4267: 'initializing' : conversi
on from 'size_t' to 'const int', possible loss of data
11>..\libvpx\test\datarate_test.cc(94): warning C4244: 'initializing' : conversi
on from 'int64_t' to 'const double', possible loss of data
11>  encode_test_driver.cc
11>..\libvpx\test\encode_test_driver.cc(169): warning C4267: 'argument' : conver
sion from 'size_t' to 'int', possible loss of data
11>  error_resilience_test.cc
11>..\libvpx\test/i420_video_source.h(52): warning C4800: 'FILE *' : forcing val
ue to bool 'true' or 'false' (performance warning)
11>..\libvpx\test/i420_video_source.h(55): warning C4267: 'argument' : conversio
n from 'size_t' to 'long', possible loss of data
11>  keyframe_test.cc
11>..\libvpx\test/i420_video_source.h(52): warning C4800: 'FILE *' : forcing val
ue to bool 'true' or 'false' (performance warning)
11>..\libvpx\test/i420_video_source.h(55): warning C4267: 'argument' : conversio
n from 'size_t' to 'long', possible loss of data
11>  resize_test.cc
11>..\libvpx\test\resize_test.cc(93): warning C4244: 'argument' : conversion fro
m 'const vpx_codec_pts_t' to 'unsigned int', possible loss of data
11>..\libvpx\test\resize_test.cc(94): warning C4244: 'argument' : conversion fro
m 'const vpx_codec_pts_t' to 'unsigned int', possible loss of data
11>  md5_utils.c
11>  decode_test_driver.cc
11>  test_vector_test.cc
11>..\libvpx\test/ivf_video_source.h(50): warning C4800: 'uint8_t *' : forcing v
alue to bool 'true' or 'false' (performance warning)
11>..\libvpx\test/ivf_video_source.h(55): warning C4800: 'FILE *' : forcing valu
e to bool 'true' or 'false' (performance warning)
11>..\libvpx\test\test_vector_test.cc(74): warning C4800: 'FILE *' : forcing val
ue to bool 'true' or 'false' (performance warning)
11>  vp8_boolcoder_test.cc
11>  idctllm_test.cc
11>  intrapred_test.cc
11>  pp_filter_test.cc
11>  sad_test.cc
11>  set_roi.cc
11>  sixtap_predict_test.cc
11>  subtract_test.cc
11>..\libvpx\test\subtract_test.cc(58): warning C4309: '=' : truncation of const
ant value
11>  vp8_fdct4x4_test.cc
11>  vp9_boolcoder_test.cc
11>  idct8x8_test.cc
11>  fdct4x4_test.cc
11>  fdct8x8_test.cc
11>  variance_test.cc
11>  dct32x32_test.cc
11>Link:
11>  test_libvpx.vcxproj -> c:\on2\win64\x64\Release\test_libvpx.exe
11>
11>Build succeeded.
11>
11>Time Elapsed 00:00:34.69
========== Build: 17 succeeded, 0 failed, 0 up-to-date, 0 skipped 

Original issue reported on code.google.com by fbarch...@google.com on 18 Jan 2013 at 3:12

[GoogleCodeExporter]

msys on windows doesnt build, but cross build does with warnings.
These are the warnings as of v1.2.0-1570-g7f5e4fd (Feb 3, 2013)

x86_64-w64-mingw32-gcc  -fno-common -m64 -fomit-frame-pointer -O3 -Wall 
-Wdeclaration-after-statement -Wdisabled-optimization -Wpoin
ter-arith -Wtype-limits -Wcast-qual -Wvla -Wimplicit-function-declaration 
-Wuninitialized -Wunused-variable -Wunused-but-set-variabl
e -Wno-unused-function -I. -I"../libvpx" -c -o vp8/encoder/ethreading.c.o 
../libvpx/vp8/encoder/ethreading.c
../libvpx/vp8/encoder/ethreading.c: In function `vp8cx_create_encoder_threads':
../libvpx/vp8/encoder/ethreading.c:535:9: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:553:13: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:571:17: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:572:17: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:574:13: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:589:13: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:590:13: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:603:21: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:604:21: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:606:17: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:607:17: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:608:17: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c: In function `vp8cx_remove_encoder_threads':
../libvpx/vp8/encoder/ethreading.c:635:17: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:637:17: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:641:13: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:644:9: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:645:9: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/ethreading.c:646:9: warning: value computed is not used 
[-Wunused-value]
x86_64-w64-mingw32-gcc  -fno-common -m64 -fomit-frame-pointer -O3 -Wall 
-Wdeclaration-after-statement -Wdisabled-optimization -Wpoin

e -Wno-unused-function -I. -I"../libvpx" -c -o vp8/encoder/onyx_if.c.o 
../libvpx/vp8/encoder/onyx_if.c
../libvpx/vp8/encoder/onyx_if.c: In function `vp8_change_config':
../libvpx/vp8/encoder/onyx_if.c:1400:9: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/onyx_if.c: In function `encode_frame_to_data_rate':
../libvpx/vp8/encoder/onyx_if.c:3276:9: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/onyx_if.c:4359:9: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/onyx_if.c:4369:9: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/encoder/onyx_if.c: In function `vp8_get_preview_raw_frame':
../libvpx/vp8/encoder/onyx_if.c:5359:13: warning: value computed is not used 
[-Wunused-value]

e -Wno-unused-function -I. -I"../libvpx" -c -o vp8/decoder/threading.c.o 
../libvpx/vp8/decoder/threading.c
../libvpx/vp8/decoder/threading.c: In function `vp8_decoder_create_threads':
../libvpx/vp8/decoder/threading.c:685:13: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/decoder/threading.c:693:13: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/decoder/threading.c:696:9: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/decoder/threading.c: In function `vp8_decoder_remove_threads':
../libvpx/vp8/decoder/threading.c:849:13: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/decoder/threading.c:854:13: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/decoder/threading.c:857:9: warning: value computed is not used 
[-Wunused-value]
../libvpx/vp8/decoder/threading.c: In function `vp8mt_decode_mb_rows':
../libvpx/vp8/decoder/threading.c:917:5: warning: value computed is not used 
[-Wunused-value]
x86_64-w64-mingw32-gcc  -fno-common -m64 -fomit-frame-pointer -O3 -Wall 
-Wdeclaration-after-statement -Wdisabled-optimization -Wpoin
ter-arith -Wtype-limits -Wcast-qual -Wvla -Wimplicit-function-declaration 
-Wuninitialized -Wunused-variable -Wunused-but-set-variabl

e -Wno-unused-function -I. -I"../libvpx" -c -o vp9/common/vp9_entropymv.c.o 
../libvpx/vp9/common/vp9_entropymv.c
../libvpx/vp9/common/vp9_entropymv.c: In function `increment_nmv_component':
../libvpx/vp9/common/vp9_entropymv.c:108:19: warning: `c' may be used 
uninitialized in this function [-Wuninitialized]
../libvpx/vp9/common/vp9_entropymv.c:97:17: note: `c' was declared here
../libvpx/vp9/common/vp9_entropymv.c: In function `vp9_get_mv_class':
../libvpx/vp9/common/vp9_entropymv.c:108:19: warning: `c' may be used 
uninitialized in this function [-Wuninitialized]

e -Wno-unused-function -I. -I"../libvpx" -c -o vp9/common/vp9_invtrans.c.o 
../libvpx/vp9/common/vp9_invtrans.c
In file included from ../libvpx/vp9/common/vp9_invtrans.h:16:0,
                 from ../libvpx/vp9/common/vp9_invtrans.c:11:
../libvpx/vp9/common/vp9_blockd.h: In function `get_tx_type_8x8':
../libvpx/vp9/common/vp9_blockd.h:423:21: warning: `b_mode' may be used 
uninitialized in this function [-Wuninitialized]
../libvpx/vp9/common/vp9_blockd.h: In function `get_tx_type_4x4':
../libvpx/vp9/common/vp9_blockd.h:423:21: warning: `b_mode' may be used 
uninitialized in this function [-Wuninitialized]
x86_64-w64-mingw32-gcc  -fno-common -m64 -fomit-frame-pointer -O3 -Wall 
-Wdeclaration-after-statement -Wdisabled-optimization -Wpoin

ter-arith -Wtype-limits -Wcast-qual -Wvla -Wimplicit-function-declaration 
-Wuninitialized -Wunused-variable -Wunused-but-set-variabl
e -Wno-unused-function -I. -I"../libvpx" -c -o vp9/encoder/vp9_encodeintra.c.o 
../libvpx/vp9/encoder/vp9_encodeintra.c
In file included from ../libvpx/vp9/common/vp9_entropymv.h:17:0,
                 from ../libvpx/vp9/encoder/vp9_block.h:15,
                 from ../libvpx/vp9/encoder/vp9_quantize.h:14,
                 from ../libvpx/vp9/encoder/vp9_encodeintra.c:13:
../libvpx/vp9/common/vp9_blockd.h: In function `get_tx_type_4x4':
../libvpx/vp9/common/vp9_blockd.h:423:21: warning: `b_mode' may be used 
uninitialized in this function [-Wuninitialized]
e -Wno-unused-function -I. -I"../libvpx" -c -o vp9/decoder/vp9_decodframe.c.o 
../libvpx/vp9/decoder/vp9_decodframe.c
In file included from ../libvpx/vp9/common/vp9_loopfilter.h:16:0,
                 from ../libvpx/vp9/common/vp9_onyxc_int.h:17,
                 from ../libvpx/vp9/decoder/vp9_onyxd_int.h:16,
                 from ../libvpx/vp9/decoder/vp9_decodframe.c:12:
../libvpx/vp9/common/vp9_blockd.h: In function `get_tx_type_8x8':
../libvpx/vp9/common/vp9_blockd.h:423:21: warning: `b_mode' may be used 
uninitialized in this function [-Wuninitialized]
../libvpx/vp9/common/vp9_blockd.h: In function `get_tx_type_4x4':

e -Wno-unused-function -I. -I"../libvpx" -c -o vp9/decoder/vp9_detokenize.c.o 
../libvpx/vp9/decoder/vp9_detokenize.c
In file included from ../libvpx/vp9/decoder/vp9_detokenize.c:12:0:
../libvpx/vp9/common/vp9_blockd.h: In function `get_tx_type':
../libvpx/vp9/common/vp9_blockd.h:423:21: warning: `b_mode' may be used 
uninitialized in this function [-Wuninitialized]
../libvpx/vp9/common/vp9_blockd.h:423:21: warning: `b_mode' may be used 
uninitialized in this function [-Wuninitialized]
x86_64-w64-mingw32-gcc  -fno-common -m64 -fomit-frame-pointer -O3 -Wall 
-Wdeclaration-after-statement -Wdisabled-optimization -Wpoin

Original comment by fbarch...@chromium.org on 4 Feb 2013 at 5:50

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

VP9 bitstream is not yet finalized 

Original comment by albe...@google.com on 14 Mar 2013 at 10:27

• Changed state: Available
• Added labels: Mstone-12
• Removed labels: ****

[GoogleCodeExporter]

On Chrome I only see 2 warnings

d:\src\chrome\src>call python build\gyp_chromium --depth=. -Dbuildtype=Dev -G 
msvs_version=2012 -fninja chrome\chrome.gyp
Enabled Psyco JIT.
Updating projects from gyp files...
ninja: Entering directory `out/Debug'
[2647/2995] CC obj\third_party\libvpx\source\libvpx\vp9\libvpx.vp9_dx_iface.obj
d:\src\chrome\src\third_party\libvpx\source\libvpx\vp9\vp9_dx_iface.c(420) : 
warning C4018: '<' : signed/unsigned mismatch
d:\src\chrome\src\third_party\libvpx\source\libvpx\vp9\vp9_dx_iface.c(423) : 
warning C4018: '<' : signed/unsigned mismatch

Original comment by fbarch...@google.com on 9 May 2013 at 8:24

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Same warning on webrtc build 

set GYP_DEFINES=target_arch=ia32
python build\gyp_chromium --depth=. -G msvs_version=2012 -fninja webrtc.gyp
ninja -C out\Debug

ninja: Entering directory `out\Debug'
[729/1673] CXX 
obj\webrtc\modules\audio_device\win\audio_device.audio_device_core_win.obj
>> INFO: WEBRTC_WINDOWS_CORE_AUDIO_BUILD is defined
[1503/1673] CC obj\third_party\libvpx\source\libvpx\vp9\libvpx.vp9_dx_iface.obj
d:\src\webrtc\trunk\third_party\libvpx\source\libvpx\vp9\vp9_dx_iface.c(420) : 
warning C4018: '<' : signed/unsigned mismatch
d:\src\webrtc\trunk\third_party\libvpx\source\libvpx\vp9\vp9_dx_iface.c(423) : 
warning C4018: '<' : signed/unsigned mismatch
[1672/1673] LINK voe_cmd_test.exe

Original comment by fbarch...@google.com on 21 May 2013 at 10:38

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Index: D:/src/webrtc/trunk/third_party/libvpx/source/libvpx/vp9/vp9_dx_iface.c
===================================================================
--- D:/src/webrtc/trunk/third_party/libvpx/source/libvpx/vp9/vp9_dx_iface.c     
(revision 196669)
+++ D:/src/webrtc/trunk/third_party/libvpx/source/libvpx/vp9/vp9_dx_iface.c     
(working copy)
@@ -417,10 +417,10 @@
       int i, j;
       const uint8_t *x = data + data_sz - index_sz + 1;

-      for (i = 0; i < frames; i++) {
+      for (i = 0; i < (int)frames; i++) {
         uint32_t this_sz = 0;

-        for (j = 0; j < mag; j++)
+        for (j = 0; j < (int)mag; j++)
           this_sz |= (*x++) << (j * 8);
         sizes[i] = this_sz;
       }

Original comment by fbarch...@google.com on 2 Jun 2013 at 10:00

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Fixed in https://gerrit.chromium.org/gerrit/57499

Original comment by jkoles...@google.com on 4 Jun 2013 at 8:11

• Changed state: Fixed
• Added labels: Component-libvpx
• Removed labels: ****