Repo setup script - Githubissues

MariaDB / mariadb-docker

Docker Official Image packaging for MariaDB

https://mariadb.org

GNU General Public License v2.0

770 stars 438 forks source link

Repo setup script #353

Closed timofeyturenko closed 3 years ago

timofeyturenko commented 3 years ago

Use https://downloads.mariadb.com/MariaDB/mariadb_repo_setup script instead of manual configuration of the repository
Add possibility to define external CI repository as argument

timofeyturenko commented 3 years ago

To propagate setup-custom-repository.sh to each image it needs to be copied. Include this in: https://github.com/MariaDB/mariadb-docker/blob/master/update.sh#L73

Run ./update.sh as part of the pull request.

updated

tianon commented 3 years ago

You'll probably want to (re-)read through https://github.com/docker-library/official-images#review-guidelines and make sure this is in line with the downstream program guidelines.

grooverdan commented 3 years ago

Per https://github.com/docker-library/official-images#image-build the download and run a repo script is unacceptable without authentication/verification. It also fails to provide ppc64le architecture.

setup-custom-repository.sh script fails https://github.com/docker-library/official-images#clarity criteria.

Please provide feedback if #355 suites your needs or how it could be improved to do so.