search

MariaDB / mariadb-docker

Docker Official Image packaging for MariaDB
https://mariadb.org
GNU General Public License v2.0
770 stars 438 forks source link

Adding a Dockerfile HEALTHCHECK that uses healthcheck.sh #419

Closed abernier closed 2 years ago

abernier commented 2 years ago

Hi,

A healthcheck.sh script is here.

What about taking advantage of it inside the Dockerfile within a HEALTHCHECK instruction, something like:

HEALTHCHECK CMD /usr/local/bin/healthcheck.sh

Thank you

grooverdan commented 2 years ago

It wasn't allowed because of https://github.com/docker-library/faq#healthcheck

Thanks for making me dig up the reference, it made me realize that https://github.com/docker-library/healthcheck/blob/master/mysql/Dockerfile.mariadb can be updated.

I'll get one more healthcheck fix 6d048b85e0baa3f5ed7bf37da193eef785ee2098 submitted soon. --su=mysql as a work around for now.