search

MariaDB / mariadb-docker

Docker Official Image packaging for MariaDB
https://mariadb.org
GNU General Public License v2.0
755 stars 436 forks source link

MDBF-568 Fix 11.x missing mysql symlinks #514

Closed LinuxJedi closed 1 year ago

LinuxJedi commented 1 year ago

During apt --no-install-recommends is used which means the -compat packages, which contain the symlinks for mysql command line tools, was not installed for 11.x.

This patch explicitly adds them back.

fauust commented 1 year ago

LGTM, @grooverdan can you merge and create PR on docker's official repo if it's OK for you?

martadinata666 commented 1 year ago

Just a thought doesn't this defeat the purpose of https://jira.mariadb.org/browse/MDEV-30201 ? One thing that may do is to create some announcement to entrypoint that mysqld should be replaced by mariadbd, rather than keeping compat packages. 💭

LinuxJedi commented 1 year ago

Just a thought doesn't this defeat the purpose of https://jira.mariadb.org/browse/MDEV-30201 ? One thing that may do is to create some announcement to entrypoint that mysqld should be replaced by mariadbd, rather than keeping compat packages. thought_balloon

The answer is a bit more nuanced than that. The original intention was to deprecate with warnings in 11.0 and make it a "recommends" package for RPM/DEB so that for many it was still installed by default. We didn't intend for the consequences of that to be that it was removed from the Docker image.

All that being said, the one instance we know of where it has affected someone, it was due their custom healthcheck code which could have been implemented a little better. We have provided them with a way to do this correctly in their CI.

So, although this was not intentional to do it here and now, this is likely the perfect time and place to do it. Unless we get feedback with a use-case where this is needed, this PR will be closed and we will make sure this is documented.

martadinata666 commented 1 year ago

I see, i thought docker image mariadb:11, intentional removing of compat thing to introduce transition mysqld to mariaddbd, followed by repository that had compat installed, and lead to compat removal. 👍🏼

grooverdan commented 1 year ago

10.6+ container images already use the native mariadb names. So the compat is explicitly in the user generated extension domain.

LinuxJedi commented 1 year ago

Unlikely we will do this, blog post given reasoning.

fauust commented 1 year ago

https://mariadb.org/mariadb-server-docker-official-images-healthcheck-without-mysqladmin/