Closed a97410985 closed 3 years ago
sorry for not code formatting my code, I rebase and force push to my PR. Seems fine.
Hey @a97410985! No worries, we're lucky we can format so easy using this tool. Please update the PR again, sorry for this, when you rebased, you missed the self._styled_result(result)
call I introduced before your commit.
Thanks a lot for the contribution @a97410985! Awesome work :-)
related to https://github.com/MariaDB/mariadb_kernel/issues/15
my ideas :
mariadb_kernel/kernel.py is reponsible for execute the code when frontend run a cell, and the function handle this is
do_execute(...)
,which would parse sql and magic command and execute it. The following code for execute sql statements.when error occur,
if self.mariadb_client.iserror():
will handle this. After that, if the result is empty we should display a pure text, show ''Query OK", make the user assure execution successdemonstration(video)
https://www.youtube.com/watch?v=-3GKlLQjwGA&ab_channel=%E6%B1%9F%E6%96%B0%E7%9F%A5