search

MariaDB / mariadb_kernel

A MariaDB Jupyter kernel
BSD 3-Clause "New" or "Revised" License
30 stars 21 forks source link

Added support for running multiple notebooks #25

Closed jonakarl closed 3 years ago

jonakarl commented 3 years ago

CAVEATE: Lingering directories (where socket and pid file are stored) are not deleted.

Closes #24

robertbindar commented 3 years ago

Also please don't forget about the the pre-commit check. CI/tests should be green for this PR, I've re-run the jobs to use the new docker image I pushed yesterday.

jonakarl commented 3 years ago

The pre-commit fail afaik is a trailing whitespace in the Dockerfile (which I did not touched) :-)

Will look into it on Friday, on parental leave today and holiday tomorrow.

robertbindar commented 3 years ago

The pre-commit fail afaik is a trailing whitespace in the Dockerfile (which I did not touched) :-)

Will look into it on Friday, on parental leave today and holiday tomorrow.

Right again, you fork might not have the commit in which I fixed the dockerfile, sorry for this.

jonakarl commented 3 years ago

I did not want to clutter this PR with it but added my Dockefiler and build script in https://github.com/jonakarl/mariadb_kernel/tree/dockerstacks-tests (these scripts is what I have been using to test during the development).

To run it execute (in the root of the mariadb_kernel repo) : ./dockerstacks_build.sh && docker run -it -p 8888:8888 mariadb_kernel

caveate: if you look closely you will notice we use jupyter/datascience-notebook:hub-1.1.0 and not the latest and that is only due to a dependency issue in our own environment (one of the packages we use does not have a release for jupyterhub 3.0 yet). I did a quick test with the latest version of jupyterhub and also that works as expected.

robertbindar commented 3 years ago

Sorry for the delay @jonakarl :( Quick question: will the script file and docker setup work with no issues for any user with just docker installed? That would be amazing, I probably need it myself too as I plan to feed a Dockerfile to mybinder so that I do some more customizations than I'm able to using postBuild and co. scripts.

jonakarl commented 3 years ago

Quick answer; (if you mean "my Dockerfile") yes that should work for anyone with docker.

Nothing is persistent unless you mount /home/jovyan/work in the container though.

Mvh Jonas

Hämta Outlook för Androidhttps://aka.ms/AAb9ysg

From: Robert Bindar @.> Sent: Tuesday, May 18, 2021 3:31:37 PM To: MariaDB/mariadb_kernel @.> Cc: Jonas Karlsson @.>; Mention @.> Subject: Re: [MariaDB/mariadb_kernel] Added support for running multiple notebooks (#25)

Sorry for the delay @jonakarlhttps://github.com/jonakarl :( Quick question: will the script file and docker setup work with no issues for any user with just docker installed? That would be amazing, I probably need it myself too as I plan to feed a Dockerfile to mybinder so that I do some more customizations than I'm able to using postBuild and co. scripts.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/MariaDB/mariadb_kernel/pull/25#issuecomment-843174165, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACFVVF3F4C5PUECMPGXODHDTOJT3TANCNFSM44U6UT2A.

När du skickar e-post till Karlstads universitet behandlar vi dina personuppgifterhttps://www.kau.se/gdpr. When you send an e-mail to Karlstad University, we will process your personal datahttps://www.kau.se/en/gdpr.