search

MariaDB / mariadb_kernel

A MariaDB Jupyter kernel
BSD 3-Clause "New" or "Revised" License
30 stars 20 forks source link

Make it possible to configure initial database to use in mariadb_config.json #38

Closed sunxiaoguang closed 1 year ago

sunxiaoguang commented 2 years ago

Make it possible to configure initial database to use in mariadb_config.json

sunxiaoguang commented 2 years ago

Issue: closes #39

grooverdan commented 2 years ago

Looks all right to me. Thanks.

sunxiaoguang commented 2 years ago

It looks strange that the linter failed due to failing to import a package. I tried to run black locally and couldn't reproduce it.

sunxiaoguang commented 2 years ago

Looks all right to me. Thanks.

Hello @grooverdan , thanks for replying. Could you please give me some hint about why the test failed. I could reproduce it and it doesn't look like caused by changes in commit. Thanks.

grooverdan commented 2 years ago

I couldn't work it out in a brief look when I last looked at it. Will need local testing.

LinuxJedi commented 1 year ago

CI was failing due to a bug in the CI. I've rebased against master to fix that.