search

MariaTheDinkus / cc-tweaked-fabric

CC: Tweaked ported for Fabric 1.14.x
Other
19 stars 8 forks source link

FishyTurtle #12

Open crabdancing opened 3 years ago

crabdancing commented 3 years ago

Fishing is a very boring repetitive task. There are many mods that automate this, but they do so in uninteresting ways that don't tend to have much challenge. It should be possible to equip a turtle with a fishing rod and make a FishyTurtle, and automate it via programming! :D

I've discussed this with upstream, and it seems like the upstream obstacles shouldn't apply to Fabric due to the mixin system. The only thing is that downstream might end up having some unique features that upstream doesn't, if upstream doesn't feel like using MixinBootstrap or a similar solution. How do we feel about this?

Devan-Kerman commented 3 years ago

mixin is now included in forge so they shouldn't have a problem

crabdancing commented 3 years ago

Whoops, it's supposed to be marked as a feature request, not a bug...

crabdancing commented 3 years ago

@Devan-Kerman it looks like upstream is reluctant to implement this, so it might end up being a fabric-exclusive feature if we implement it here.

Devan-Kerman commented 3 years ago

we decided not to have any fabric-exclusive features and to rather make an extension mod later on to make it easier to track upstream

crabdancing commented 3 years ago

Damn, I guess it won't get added to either version unless upstream changes their mind. :(

I'd be willing to work on a ComputerCraft addon for FishyTurtle once I get a bit more modding practice. Can you point me to some example code that extends CC-tweaked-fabric?

Devan-Kerman commented 3 years ago

I actually dunno how the CC:T api works, I just helped porting the mod, but digging around the code and mixing in whenever u need something changed is prolly the extent of my knowledge

crabdancing commented 3 years ago

Damn, fair enough.

crabdancing commented 3 years ago

I've never actually made mixins for another mod -- only Minecraft itself. Is mod loading order something to be concerned about, and how should it be addressed?

Devan-Kerman commented 3 years ago

no, just remember @Mixin(remap = false)

crabdancing commented 3 years ago

Okay, thanks! ^_^