search

MariaTheDinkus / cc-tweaked-fabric

CC: Tweaked ported for Fabric 1.14.x
Other
19 stars 8 forks source link

Change turtle block breaking to call onBreak #26

Closed techninja1008 closed 3 years ago

techninja1008 commented 3 years ago

Fixes #25.

Specifically, this changes the first call of Block.onBroken to Block.onBreak, to make the logic consistent with ServerPlayerInteractionManager.

Devan-Kerman commented 3 years ago

has this been tested, if so, thank you for your work

techninja1008 commented 3 years ago

It has, turtles can now break and pick up other turtles and computers successfully

Devan-Kerman commented 3 years ago

I'll merge your pull request, are you planning on making any more soon or should I publish a release on the curseforge

techninja1008 commented 3 years ago

I'm currently in the process of a fix for #24

Devan-Kerman commented 3 years ago

that was fixed upstream I think, might be best to go off of that

Devan-Kerman commented 3 years ago

do you want to be added to the repository?

techninja1008 commented 3 years ago

If you want, yeah. I will put it out there that this is my first experience with Fabric, although I've done Forge modding and other java (and scala) work as well.

Devan-Kerman commented 3 years ago

that's fine

techninja1008 commented 3 years ago

Didn't realize renaming the branch would close this PR, see #28