Closed nullified33 closed 3 years ago
What is the point of this PR? Outside of the texture changes and some string edits to adventure.lua (are those from upstream of just arbitrary changes?), this PR only contains other PRs that have already been merged (from my repo).
There are a few new commits from Merith-TK's patchwork project that you pulled, but those could be pulled into here more directly when Merith-TK is ready.
What is the point of this PR? Outside of the texture changes and some string edits to adventure.lua (are those from upstream of just arbitrary changes?), this PR only contains other PRs that have already been merged (from my repo).
There are a few new commits from Merith-TK's patchwork project that you pulled, but those could be pulled into here more directly when Merith-TK is ready.
Tweaked some stuff in adventure
i probably will edit more stuff later on
Is it from upstream (the forge CC: Tweaked project)?
no
Upstream from Merith-TK
Also weirldy enough, my readme has no conflicts, but Merith-TK's does
Are you applying the updates by hand instead of properly merging the relevant commits?
Yeah these appear to @Merith-TK commits that are copy pasted and recommitted.
Yeah these appear to @Merith-TK commits that are copy pasted and recommitted.
recently i undid a lot of them
I would request you to stop what you are doing, if you wanted my work added to this repo, you should've requested me to make a PR.
Also, these forks are feature Parity forks. Meaning that they intend to have the features and functions as the mainstream CC:Tweaked.
Any and all changes that are not directly a quilt related bug fix. Are to go to CC:T, not here.
Also. I would appreciate it if you would not steal code I have written for CC:Restiched, and simply rebrand it as your own fork. Also I'm pretty sure that violates liscencing, I may be wrong,
It is still morally unethical to take someone else's work and brand it as your own.
Also. I would appreciate it if you would not steal code I have written for CC:Restiched, and simply rebrand it as your own fork. Also I'm pretty sure that violates liscencing, I may be wrong,
It is still morally unethical to take someone else's work and brand it as your own.
i undid that code and sorry
ill delete the branch
I would also reccomend learning to use git a bit more before attempting a PR like this.
As with git, if your fork is out of date and you made edits. Odds are, you can merge the latest version with your current version, assuming there are no conflicts in the edits.
I would also reccomend learning to use git a bit more before attempting a PR like this.
As with git, if your fork is out of date and you made edits. Odds are, you can merge the latest version with your current version, assuming there are no conflicts in the edits.
thanks
I would also reccomend learning to use git a bit more before attempting a PR like this.
As with git, if your fork is out of date and you made edits. Odds are, you can merge the latest version with your current version, assuming there are no conflicts in the edits.
good luck with your fork
I would also reccomend learning to use git a bit more before attempting a PR like this.
As with git, if your fork is out of date and you made edits. Odds are, you can merge the latest version with your current version, assuming there are no conflicts in the edits.
nah i use desktop, git i have but is probably outdated or something like that
You need to learn how to use git before contributing to a larger project like this with multiple devs.
Otherwise your PR's won't be accepted. Looking at your commits here, this appears to be a clusterfuck of commits.
Try using Git Kraken. It works well and is what I use for my git code maintenance
You need to learn how to use git before contributing to a larger project like this with multiple devs.
Otherwise your PR's won't be accepted. Looking at your commits here, this appears to be a clusterfuck of commits.
ok
Try using Git Kraken. It works well and is what I use for my git code maintenance
also ill try it
is it this https://www.gitkraken.com/
I would request you to stop what you are doing, if you wanted my work added to this repo, you should've requested me to make a PR.
Also, these forks are feature Parity forks. Meaning that they intend to have the features and functions as the mainstream CC:Tweaked.
Any and all changes that are not directly a quilt related bug fix. Are to go to CC:T, not here.
pr failed cause of some readme thing, that is why i copied and pasted
also github gave me a "this branch already exsists" error
please move elsewhere for the discussion, ill be locking this
A quick checklist
src/test/resources/test-rom/spec
and can be run with./gradlew check
.