search

MarianArlt / kde-plasma-chili

The hottest login theme around for KDE Plasma 5
https://www.opendesktop.org/p/1214121
GNU General Public License v3.0
208 stars 31 forks source link

Allow choosing the font #15

Closed flipwise closed 6 years ago

flipwise commented 6 years ago

Hi there,

first of all thank you so much for this fantastic theme, the last version is especially great given how configurable it is.

I was wondering if the fonts could also be made configurable. From what I can tell, this would mean simply replacing all the hardcoding of Noto Sans with font.family: config.displayFont and then adding the displayFont option in theme.conf.

I tested it out myself on the latest version and it seems to have worked fine (but perhaps the user should be warned not to use non-systemwide fonts)

MarianArlt commented 6 years ago

As you mentioned this is rather easy to implement. Personally, as a designer I cringe before such customizations because people tend to customize things to a level where it's not a smooth user experience any more. But: I realize and know that the best fact about Linux is just that. It can be mine. The way I like it. This setting especially is pretty dangerous in terms of legibility and interface readability. Nevertheless it's a feature and as such I'll have it implemented in the next release. Care must be taken though to write the correct annotation in the config of the font name. This can be confusing for people not used to font management.

flipwise commented 6 years ago

Being passionate about fonts and having done GFX as a hobby before, I totally get what you're saying. I've seen my fair share of Linux users' cringey UI fonts - from monospaced ones to serif fonts. Personally I favor Lato and turn off font hinting to remain true to the typeface.

But my main motivation with suggesting this is mostly just to be able to easily achieve cohesion between the desktop and SDDM if you don't use Noto Sans. The option would also help a lot because SDDM isn't very customizable itself.

As for wrong values being put in, I just tested what happens and it just defaults to Sans... ugly, but doesn't break anything that I can see.

Anyway, thanks for hearing me out :)

MarianArlt commented 6 years ago

Added this in the latest version. Please upgrade to 0.5.4. b2188228cda182a2cf7830761d8161aed6b3f0fd