search

MarianArlt / kde-plasma-chili

The hottest login theme around for KDE Plasma 5
https://www.opendesktop.org/p/1214121
GNU General Public License v3.0
208 stars 31 forks source link

Can't set custom background in v0.5.4 #19

Closed r3b311i0n closed 6 years ago

r3b311i0n commented 6 years ago

Setting a custom background using System Settings or by editing the theme.conf.user file has no effect and the default background is used instead. Downgrading to 0.5.3 fixes the issue.

env:

Arch Linux Installed using AUR PKGBUILD sddm: 0.18.0 plasma: 5.14.2

mockroot commented 6 years ago

I'm the maintainer of that package and it's not supported by the creator of the theme. That being said, I don't have any issue with theme.conf.user in my system or in Virtualbox machine and don't know where the problem might be. I have .jpg background file in the theme directory and this config:

[General]
Background=my-background.jpg

Of course, you can directly edit theme.conf file but it will be overwritten when updating to new version. Install manually if it doesn't work.

Edit: Just tried some things. If you use "background=", it doesn't work. Try "Background=" (beginning with uppercase) instead. I don't know why though.

mockroot commented 6 years ago

It may be related to this change. @MarianArlt SDDM creates a line starting with a lower case letter but the theme expects for upper case.

r3b311i0n commented 6 years ago

Yup, using capitalised Background fixes it. And thanks for the responses! :smile:

MarianArlt commented 6 years ago

Yes indeed, when creating the theme.conf.user file the variable is called "background" and I lately wanted to unify my theme.conf variables to be all uppercase. I didn't test enough with this. To fix this I'll rewrite the logic a little so that the lowercase background variable from theme.conf.user takes precedence. Thanks @r3b311i0n for pointing this out. And to @mockroot for helping! I'll fix this asap!

P.D.: I actually realize I did this comparison right by default for my latest two themes ^^;

MarianArlt commented 6 years ago

Github release is up to date with v0.5.5. 279cdf8e3fbe0cea0e8462c22e0e9f61f0745e50 should fix this. Uploading to opendesktop now.