Mariano-Github / Edge-Drivers-Beta

Edge Driver Beta Modified for Created
Apache License 2.0
117 stars 119 forks source link

Add Fingerprint NodOn #63

Open AltyorFig opened 1 year ago

AltyorFig commented 1 year ago

Hello! New to the world of Smartthing EDGE, we had our devices registered in the previous version in .groovy. I want to request add device fingerprint to zigbee-multi-switch-v4.5-childs-edge.

Thank you in advance for sharing this with the community.

My information for the 2 fingerprint are:

The both are dual switch (2 endpoints).

https://nodon.fr/en/nodon/zigbee-on-off-lighting-relay-switch/

Thanks in advance for all your help. Emilie

Mariano-Github commented 1 year ago

Hi Emilie

Added to this driver version

───────────────────────────────────────────────────
 Driver Id    e9bfd289-1d51-499e-8c64-d564d1868ad2 
 Name         Zigbee Multi Switch and Child Mc     
 Version      2023-03-31T15:28:33.368359212        
───────────────────────────────────────────────────
- id: "NodOn/SIN-4-1-20"
    deviceLabel: Multifunction Relay Switch
    manufacturer: NodOn
    model: SIN-4-1-20
    deviceProfileName: two-switch
  - id: "NodOn/SIN-4-1-20-PRO"
    deviceLabel: Multifunction Relay Switch PRO
    manufacturer: NodOn
    model: SIN-4-1-20-PRO
    deviceProfileName: two-switch
AltyorFig commented 1 year ago

Hi @Mariano-Github ,

Thank you for your reactivity, I apologize in advance, I just realized that I made a naming error (id + device label), could you update?

Also, once this update is done, to be able to test, can we add it with the Smartthings CLI commands and also for publication, is this done in the same way as the other modules present in the community? Thanks for all that work.

Mariano-Github commented 1 year ago

Hi Modified in this driver version

You can install driver in your hub from channel link in my github README.md If you already your hub enrolled to my channel, you can also install it with the CLI Once device paired you can view the running logs with the CLI

───────────────────────────────────────────────────
 Driver Id    e9bfd289-1d51-499e-8c64-d564d1868ad2 
 Name         Zigbee Multi Switch and Child Mc     
 Version      2023-04-03T15:52:42.086859975        
───────────────────────────────────────────────────
- id: "NodOn/SIN-4-2-20"
    deviceLabel: Lighting Relay Switch
    manufacturer: NodOn
    model: SIN-4-2-20
    deviceProfileName: two-switch
  - id: "NodOn/SIN-4-2-20-PRO"
    deviceLabel: Lighting Relay Switch PRO
    manufacturer: NodOn
    model: SIN-4-2-20-PRO
    deviceProfileName: two-switch
AltyorFig commented 1 year ago

Hi @Mariano-Github ,Thanks for your answer. After testing device, how can we pull request to smartthings? Is it recognize for adding product in the console for company like others?

Mariano-Github commented 1 year ago

Hi,

This driver is not an official driver, it is a personal driver.

If you want to add the fingerprints to the smartthings Zigbee Switch driver you will have to make a pull request on the github smartthings beta drivers

https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/tree/production/drivers

Mariano-Github commented 1 year ago

Hi Emile

If you need help on how to integrate the dual switches in the stock Zigbee Switch driver I can help you:

This will be created by installing the child device device for switch-2 and a simple switch for main.

With this they should work perfectly with the stock Zigbee Switch

If you have doubts you can tell me

AltyorFig commented 1 year ago

Hello @Mariano-Github ,

I really thank you for your help, I will test all the solutions that you propose to me. Sorry again for the inconvenience.

Beautiful day