search

Mariano-Github / Edge-Drivers-Beta

Edge Driver Beta Modified for Created
Apache License 2.0
116 stars 118 forks source link

Power Consumption (Watts) for Thermostat Edge Driver #84

Closed xmorand closed 1 year ago

xmorand commented 1 year ago

Hello,

Looks like theses drivers work well with Stelpro Zigbee Thermostats. On the old platform before edge drivers it was possible to get the power consumption in Watts. Any plans to have this added to the thermostat edge driver ?

Thanks,

Mariano-Github commented 1 year ago

Hi,

If smartthings made the stock DTH because it was certified, then you should tell smartthings to add it to your stock driver

xmorand commented 1 year ago

Do you know how to request Smartthings to add this ?

In the meantime I explored the folder zigbee-thermostat-stock-mc in this project and trying to reverse engineer the code to add the support - are you ok if I propose a merge request for this repo?

Mariano-Github commented 1 year ago

You can open a issue or a pull request in the official github smartthings edge drivers repository, zigbee thermostat driver

https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/tree/f0282c560d7f6061fb5d897e19578d5aaa12cb9e/drivers/SmartThings/zigbee-thermostat

xmorand commented 1 year ago

Done - https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/896

First time doing pull request for Edge Drivers - let me know if it looks good.

Mariano-Github commented 1 year ago

You should refer to the stock driver files, not mine.

If you reference the girhub of another driver than smartthings, they cannot merge it.

You can also do an issue as you wrote to me, instead a pull request

xmorand commented 1 year ago

I actually started by forking the original smartthings drivers, then incorporated the changes you made that were relevant on top of the original ones and added my own for the power metrics and home assistant compatibility - so we should be good there.