MarieComet / mc-acf-flexible-template

WordPress plugin makes it possible to save the ACF flexible content fields as templates
71 stars 20 forks source link

Your Plugin has a lot of potential, great work!!! #7

Closed carfis closed 6 years ago

carfis commented 6 years ago

Hi Marie, Today, I discovered your plugin, and it is what I always needed since I use the flexible content a lot.

I found some cases when the "Load template" and "Save template" buttons are not displayed.

  1. If the flexible content field is loaded with a clone field grafik

  2. When the Field Group has more than one field type, for example, a text field and then a flexible content: grafik

for case 1 I looked at the class MC_Acf_Flexible_Template, and I added to the actions the type=clone

// add option settings in flexible field
add_action( 'acf/render_field_settings/type=flexible_content', array( $this, 'mc_ft_acf_field_groups_add_settings' ), 10, 1 );
// add option settings in flexible field clone
add_action( 'acf/render_field_settings/type=clone', array( $this, 'mc_ft_acf_field_groups_add_settings' ), 10, 1 );

grafik

But I couldn't find how to display the save buttons.

Carlos

MarieComet commented 6 years ago

Hi Carlos, thanks for you feedback, I will test your usecases in the next days and come back to you.

Marie.

MarieComet commented 6 years ago

Hi Carlos,

After some tests :

  1. Flexible field displayed in a clone field : I can't reproduce, when I display my flexible field in a clone field ("seamless" or "group" display), the buttons appears and import/export works. So I think it's an other problem (not clone field related).

  2. Group field with flexible field and other field : I can't reproduce : image

If you want to give me an export of your fields I will do some tests.

carfis commented 6 years ago

Hi Marie, I tested the flexible content again. I think the problem was on my installation between the acf-json folder and database. I checked that on a multisite; maybe the field group was not loaded from the right place.

The fix was straightforward :( I saved the flexible content with "Save and load templates functionality" disabled and then I enabled it again.

grafik

Then grafik

grafik

Thank you very much!

MarieComet commented 6 years ago

Ok, great ! Maybe the first time you saved the option it wasn't saved correctly. I will add that in the FAQ (double save option) if button do not appears.

carfis commented 6 years ago

Yes, that is a good idea ;)

I found an issue with the clone option; I will test a little more tomorrow.

I can't save the template.

grafik

MarieComet commented 6 years ago

Ok, if needed open a new issue with details about your fields structure.