MarimerLLC / csla

A home for your business logic in any .NET application.
https://cslanet.com
MIT License
1.27k stars 406 forks source link

BusyHelper for IsBusy Change #3953

Closed Freelancingonupwork closed 6 months ago

Freelancingonupwork commented 6 months ago

csla/Source/Csla.Blazor/ViewModel.cs

 if (obj.IsBusy) 
 { 
   var stopTime = DateTime.Now + BusyTimeout; 
   while (obj.IsBusy) 
   { 
     if (DateTime.Now > stopTime) 
       throw new TimeoutException("SaveAsync"); 
     await Task.Delay(1); 
   } 
 } 

Replaced by BusyHelper class from Csla.Core to avoid the spin wait. Fixes #3936

StefanOssendorf commented 6 months ago

@Freelancingonupwork Please fix the broken test then we can merge it :)

Freelancingonupwork commented 6 months ago

@Freelancingonupwork Please fix the broken test then we can merge it :)

Freelancingonupwork commented 6 months ago

Hello,

By mistake I closed the PR. and when I reopened it. builds completed without error.

rockfordlhotka commented 6 months ago

I have noticed that there is at least one test that sporadically fails. Frustrating!