Localize code fixes and analyzers

MarimerLLC / csla

A home for your business logic in any .NET application.

https://cslanet.com

MIT License

1.27k stars 406 forks source link

Closed kant2002 closed 4 months ago

kant2002 commented 4 months ago

Closes #1352

kant2002 commented 4 months ago

I would say this is draft to gather feedback on some key decisions which I have to do.

StefanOssendorf commented 4 months ago

If it's a draft please make it a real draft. Otherwise rocky may just merge it ;)

rockfordlhotka commented 4 months ago

My first scan through the code changes is quite positive, I like what you've done so far.

Can you provide more detail about the three decision points, and what you recommend?

kant2002 commented 4 months ago

@StefanOssendorf unfortunately I press buttons first and think second. So I miss that opportunity 😄

@rockfordlhotka one by one.

previously in tests was constants which is used in analyzers. I directly use string literals now. Anyway I cannot leave test code without changes. Maybe i can get to read from prebuilt LocalizationString but for me that’s tying too much to prod code.
just voice your opinion on how I name resource strings
Just inform that I remove not used code. Maybe it indeed used by some obscure ways.

kant2002 commented 4 months ago

@rockfordlhotka can you take a look?

rockfordlhotka commented 4 months ago

I'm out of town this week, and will look when I get back.