search

MarineBioAcousticsRC / Triton

:whale: Scripps Whale Acoustics Lab :earth_americas: Scripps Acoustic Ecology Lab - Triton with remoras in development
Other
36 stars 25 forks source link

Remora for batch creating LTSAs for multiple directories #73

Open sfregosi opened 3 years ago

sfregosi commented 3 years ago

Hi MBARC!

I modified a multiDirLTSA Triton version/code that worked to batch create LTSAs for HARP data into a Remora that could be used with the latest version of Triton and should work for wav files. I am not positive it will work for all, and it could probably use some improvements/clean up, but I wanted to let you all know to see if it was of interest to anyone or if you wanted to try to add it as another branch in the MBARC Triton repository. Let me know!

Selene

kfrasier commented 2 years ago

Hi Selene,

Sorry to be so horribly slow on this. We REALLY appreciate you working on this and are very excited to incorporate your improvements. Can you put it up as a branch and we can figure out a strategy on our end for reviewing it?

Thanks again - it's super refreshing to have someone else helping to make this project better.

Kait

On Wed, Aug 4, 2021 at 12:07 PM sfregosi @.***> wrote:

Hi MBARC!

I modified a multiDirLTSA Triton version/code that worked to batch create LTSAs for HARP data into a Remora that could be used with the latest version of Triton and should work for wav files. I am not positive it will work for all, and it could probably use some improvements/clean up, but I wanted to let you all know to see if it was of interest to anyone or if you wanted to try to add it as another branch in the MBARC Triton repository. Let me know!

Selene

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MarineBioAcousticsRC/Triton/issues/73, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDOCHTALLBZBOXUJHG4P5DT3GFVPANCNFSM5BRZUKEA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

marie-r commented 2 years ago

Dear Selene,

Was this the multiple directory LTSA that I wrote from the old Triton? If it was, it required a modification to the LTSA header. If the LTSA header was modified since that was done (probably over 5 years ago), you'll need to make sure that those modifications were folded into the the new format. In any case, I agree with Kait, it's really nice to see this being added.

All my best, Marie

sfregosi commented 2 years ago

Hi Kait, First - no worries on the timing and happy and having fun working on this. The good news is @ybarkley has used this and it hasn't broken yet :)

Marie, thanks for checking on this. I built this off multiDirLTSA functions within a Triton version v1.93.20190212 that I got from Ann Allen. I suspect that means the LTSA header modification you are mentioning would not be an issue here, but I'd like to double check. Do you have access to the version you wrote/are talking about? I could maybe compare to what I was working off to be sure.

Thanks! Selene

sfregosi commented 2 years ago

Oh also, yes, will make it a branch like I did the param saving pull request by the end of the week.

sf.

sfregosi commented 2 years ago

Created pull request #77