search

MarineBioAcousticsRC / Triton

:whale: Scripps Whale Acoustics Lab :earth_americas: Scripps Acoustic Ecology Lab - Triton with remoras in development
Other
37 stars 27 forks source link

Ship Detector - Always Removing Disk-Write Noise, with simple fix #99

Closed kmerkens closed 1 year ago

kmerkens commented 1 year ago

Hi Triton team,

The Ship Detector has a check-box button to select whether one wants to exclude Disk Write noise, which is very helpful for HARP data, but not much else. It looks like the way it is coded (Lines 28-38 in sh_passage_detector.m) it always functions to remove the "Disk-Write" noise, even if the box is unchecked. A simple fix would be to change line 28 to read: if REMORA.sh.settings.diskWrite == 1, which is the value of REMORA.sh.settings.diskWrite if the checkbox is clicked. (If the check box is unchecked the value of REMORA.sh.settings.diskWrite is "Exclude Disk-Write Noise", which still exists, so the current code considers this to also mean that one should remove the Disk Writes.)

-Karli

https://github.com/MarineBioAcousticsRC/Triton/blob/0ae8a7fca95e035991e8f450461c3b8a23c4f9cf/Remoras/Ship-Detector/detection/sh_passage_detector.m#L28

asolsonaberga commented 1 year ago

Thank you Karlina, I have implemented the changes as you suggested.