search

MarineRoboticsGroup / tonioviz

Finally, a nice C++ visualization tool.
5 stars 0 forks source link

Precommit update #17

Closed alanpapalia closed 3 years ago

alanpapalia commented 3 years ago

Modernized the clang formatting to clang version 12 and updated pre-commit to correspond with this.

Note: while it will bring us into the shiny new future of formatting, this will require users to independently install clang-format-12, which is more recent than the version available on on the apt package manager.

tonioteran commented 3 years ago

The examples no longer run for me after this change: 

dyld: Library not loaded: /usr/local/opt/ceres-solver/lib/libceres.1.dylib
  Referenced from: /usr/local/lib/libopencv_sfm.4.3.0.dylib
  Reason: image not found
[1]    19776 abort      ./examples/GtsamExample1

Are you introducing some other dependencies that are not explicitly stated?

alanpapalia commented 3 years ago

Hmm that's a weird error - not introducing any new dependencies that I'm aware of

I don't have /usr/local/lib/libopencv_sfm.4.3.0.dylib on my system (I have OpenCV 4.5.3 fwiw).

The examples work for you with the most recent commit on master?

tonioteran commented 3 years ago

Yea, but I think I figured it out hahah. Sending you a PR to your PR, so after you merge, we can review this one.

alanpapalia commented 3 years ago

Based on fixes implemented in #18 we're going to merge this