Fix OpenCV and some additional cleanup. - Githubissues

MarineRoboticsGroup / tonioviz

Finally, a nice C++ visualization tool.

4 stars 0 forks source link

Fix OpenCV and some additional cleanup. #18

Closed tonioteran closed 3 years ago

tonioteran commented 3 years ago

Main lessons here:

remember to pass by const& in order to avoid unwarranted copies,
make use of range-based for loops for readability and simplicity,
write all of the docs for all of the functions

<3

alanpapalia commented 3 years ago

LGTM! Thanks for the cleanup