Take it for a spin, sonar image visualization should be beautiful.
Basically, attempts to protect the user from the fact that image sizes have to be divisible by 4 for Pangolin (see for example this issue. We round user-provided image sizes to the nearest size that is divisible by 4 and when a user calls AddImage the image is truncated to that size before displaying.
It's worth noting that this could be confusing for a user, since they'll pass a particular imgheight and imgwidth param, but if they ask for those parameters back from the Visualizer, they could be different. It seems like a better behavior than making the user resize their images, though, since we are chopping off at most 3 px.
tonioteran
commented
4 years ago
Take it for a spin, sonar image visualization should be beautiful.
Basically, attempts to protect the user from the fact that image sizes have to be divisible by 4 for Pangolin (see for example this issue. We round user-provided image sizes to the nearest size that is divisible by 4 and when a user calls
AddImagethe image is truncated to that size before displaying.It's worth noting that this could be confusing for a user, since they'll pass a particular
imgheightandimgwidthparam, but if they ask for those parameters back from the Visualizer, they could be different. It seems like a better behavior than making the user resize their images, though, since we are chopping off at most 3 px.