MarioCrane / LeagueLobby

英雄联盟自定义房间创建工具,包括5V5训练营,(血月杀等轮换模式已被官方关闭)
MIT License
350 stars 52 forks source link

spyware #5

Open Amazakay opened 3 years ago

Amazakay commented 3 years ago

it says that have spyware

MarioCrane commented 3 years ago

Are you sure open source software has spyware?

Shuunen commented 3 years ago

as @MarioCrane say it's hard to hide spyware in an open source software

I just review the source code, nothing malicious AFAIK

the only thing is I can't review libcurl_a.lib

i'm not familiar with C, is including third party lib is mandatory ? I used to work with C# where you could import things without having to embed stuff like this, also on JS/Node side there is a dependency management system that allows you to avoid bundling third party lib with your source code

MarioCrane commented 3 years ago

Thanks. libcurl_a.lib is not mandatory. I just compiled a static library. https://github.com/curl/curl

Shuunen commented 3 years ago

image

https://www.virustotal.com/gui/file/18ec6146b371d55a0526abfd03b434c1f8fa0a0569bd6d5fa20ef40ace1115da/detection

that's weird 🤔

Shuunen commented 3 years ago

Anyway I tried to compile your sources myself and lost more time doing this than doing my own version in Node Js 😋

If anyone is interested, only 60 lines of javascript, no dependencies, nothing to compile : https://github.com/Shuunen/snippets/blob/master/one-file/lol-practice-5v5.js

Download the file & run node lol-practice-5v5.js "D:\Games\Riot Games\League of Legends\lockfile"

You can also customise the game name : node lol-practice-5v5.js "D:\Games\Riot Games\League of Legends\lockfile" "My super name"

sh4rkd commented 3 years ago

node lol-practice-5v5.js "D:\Games\Riot Games\League of Legends\lockfile image

Shuunen commented 3 years ago

@sh4rkd which version of node are you using? Try to rename the file extension to .mjs

sh4rkd commented 3 years ago

.mjs

thx :)

raimo7 commented 3 years ago

@sh4rkd, @Shuunen, @MarioCrane does this still work? when I create the custom game, invite my friends and run the script or use the tool, it changes it to Practice Tool game, but kicks all the other people out of the lobby.

sh4rkd commented 3 years ago

@sh4rkd, @Shuunen, @MarioCrane does this still work? when I create the custom game, invite my friends and run the script or use the tool, it changes it to Practice Tool game, but kicks all the other people out of the lobby.

yup work fine, in pbe open custom lobby, open invite friend (only open dont invite), run the script, now you can invite your friends and play