search

MarioE / History

Logs history as a plugin for TShock.
5 stars 24 forks source link

Info Command #9

Closed Commaster closed 10 years ago

Commaster commented 10 years ago

/log command to show "statistics". Might expand to "... destroyed and ... placed"... Also a small AssemblyInfo fix. And a fresh build.

pilihp64 commented 10 years ago

I have been wanting to add a command similar to this, but I'm not sure if the command name 'log' is best. It is rather generic even if it doesn't conflict with TShock commands.

I suggest that since this is nearly the same as checking /history in many places, that it should be an extension to the /history command (allow it to take [player] [time] [radius], and default to old behavior with no arguments).

If extending history doesn't seem the best option, then I would still be okay with a slightly more relevant command name.

If you could do one of those, as well as expanding the log message to "[user] destroyed [amt], placed [amt], other edits [amt]" or similar, then I don't think I have any issues accepting.

Commaster commented 10 years ago

That last part is going to take a while...

Commaster commented 10 years ago

Done. Please check all the words, I might have missed a few. (Looks ok for me) You might want to rebuild it against TShock 4, as I'm using TShock 5 and it "might" be incompatible.

pilihp64 commented 10 years ago

There are a few small issues counting edits, wires being most noticeable, all three wire types stack, so removing wire from the same location three times is very possible.

Anyway I can merge and fix that myself since I will rebuild it anyway to be sure it works.

Commaster commented 10 years ago

And painting a wall and a tile on the same spot counts as one too :) (i.e. paint wall, place tile, paint tile) I can add more "text spam" if you wish to be even more specific...