search

MarioRicalde / SCSS.tmbundle

The TextMate SCSS Official Bundle. Now Compatible with SublimeText2.
834 stars 110 forks source link

Don't add the semicolon #141

Closed pyronaur closed 11 years ago

pyronaur commented 11 years ago

As in https://github.com/kuroir/SCSS.tmbundle/issues/124

Wardrop commented 11 years ago

Can we get this merged? This bundle is unusable with this semicolon shenanigans. Semi-colons are being injected everywhere.

stephenway commented 11 years ago

@justnorris @Wardrop I admit it's taken me a while to decide how to handle this one. However as it is important to follow the bigger brother CSS bundle in functionality, I am realizing how unnecessary this particular feature is. I've been trying this without a semicolon for a couple months now and I can't say I miss it. It is my job to weigh these things and live that change before you do.

I'm accepting this feature removal, and thanks guys for opening my eyes. The pull needs to be updated, submit a new pull and I'll merge it in, or let me know if you want me to make the change.

MarioRicalde commented 11 years ago

+1

Mario Ricalde http://mario.ricalde.mx (m) 310-597-1013 (skype) mario.ricalde.mx http://myskype.info/mario.ricalde.mx

On Fri, Jun 14, 2013 at 12:00 AM, Stephen Way notifications@github.comwrote:

@justnorris https://github.com/justnorris @Wardrophttps://github.com/WardropI admit it's taken me a while to decide how to handle this one. However as it is important to follow the bigger brother CSS bundle in functionality, I am realizing how unnecessary this particular feature is. I've been trying this without a semicolon for a couple months now and I can't say I miss it. It is my job to weigh these things and live that change before you do.

I'm accepting this feature removal, and thanks guys for opening my eyes. The pull needs to be updated, submit a new pull and I'll merge it in, or let me know if you want me to make the change.

— Reply to this email directly or view it on GitHubhttps://github.com/MarioRicalde/SCSS.tmbundle/pull/141#issuecomment-19439380 .

pyronaur commented 11 years ago

I think it's easier for all of us if you just remove the couple of lines on your own :)

stephenway commented 11 years ago

Removed auto-semicolon, commit 69e97dee6947161ae637b5e168a03fa56035cb51