MarioRicalde / SCSS.tmbundle

The TextMate SCSS Official Bundle. Now Compatible with SublimeText2.
834 stars 110 forks source link

support svg elements/properties #152

Closed schmurfy closed 4 years ago

schmurfy commented 11 years ago

I have been working more with svg elements lately (with d3.js) and having half my stylesheets highlighted as error is really annoying. is there a version of this bundle supporting svg and if not would a pull request to add svg support be accepted ?

here is an example of svg stylesheet:

line {
  fill: none;
  stroke-width: 2px;
  stroke: black;
}

here both "stroke" and "stroke-width" and it would be true if it was html but it is not :(

pepelsbey commented 11 years ago

Here's the list of supported CSS properties for SVG 1.1.

MarioRicalde commented 11 years ago

Thanks @pepelsbey

@schmurfy A pull request to add SVG support would be definitely accepted!

schmurfy commented 11 years ago

I am on it, thanks for the list :)

schmurfy commented 11 years ago

turn out there was already a bunch of properties/elements supported, I added some more of the relevant ones.

pepelsbey commented 11 years ago

There's mistype: style||stroke-opacity double delimiter. Also it's better to add complete list from the spec, not just relevan ones.

schmurfy commented 11 years ago

I fixed the typo, as for the remaining properties just give me some file to edit which do not make my eyes cross and I will do it. In its current state I consider it enough and since there was already some svg properties supported that would not be the first time either.

MarioRicalde commented 11 years ago

@stephenway can you review this and make sure it's merged in all the editor branches? I don't have the editors anymore.

Thanks!

schmurfy commented 11 years ago

This whole language file could be made much more readable if the result was just a generated version, this would allow something like that:

properties.txt

font
font-size
font-xxx

elements.txt

body
circle

The difference would only be one command to run to generate the final file, as it is now I don't even know how this can be reviewed, even editing it is a pain especially with one of the "arrays" being is in reverse order xD

Anyway I am currently using my modified version so at least I can say it works.

stephenway commented 11 years ago

@MarioRicalde Will do, I'm on vacation this week with the family so I'll get to it later this week or next week.

hbrls commented 9 years ago

@schmurfy Hey, what's the progress here?

schmurfy commented 9 years ago

I would stay that is still waiting for review xD That's the version I use and it seems to work fine for me.

hbrls commented 9 years ago

@MarioRicalde come on friends, save the world please :octocat:

MarioRicalde commented 9 years ago

Gentlemen,

We can’t automatically merge this pull request.

That's what I get at the moment. I plan to resume working on this soon.

@EnriqueCanals can you please give a crack at this and get it merged?

schmurfy commented 9 years ago

Since everything is on one line that's not a surprise it can't be merged automatically, especially since this pull request is a few years old xD