search

MarioVilas / googlesearch

Google search from Python (unofficial).
BSD 3-Clause "New" or "Revised" License
1.15k stars 393 forks source link

domain search issue #57

Closed jackson-zhipeng-chang closed 6 years ago

jackson-zhipeng-chang commented 6 years ago

Hi @MarioVilas ! So, I found that you filtered the urls that contain "google", like 'image.google.com', I'm just wondering what's the reason for that? Since I need to search the domain of 'support.google.com' now, and It works pretty well after I removed the "if 'google' not in o.netloc". Thanks!

jackson-zhipeng-chang commented 6 years ago

Okay... I see the reason why you are doing this... You don't want to have url like google map or google image ... I'll think about this and try to accommodate my case like searching 'support.google.com'

MarioVilas commented 6 years ago

Yeah, I’m sure there’s a more elegant way of doing it, TBH this library was born from a quick and dirty script I wrote for a specific task so I didn’t need to cover the case where the search results pointed to a Google domain.

jackson-zhipeng-chang commented 6 years ago

Hi @MarioVilas ! Thanks for getting back! Do you want me to work on these kinds of cases, like pointing to Google domains but not include google map or image

MarioVilas commented 6 years ago

@Zhipeng-Chang That would be awesome! :)