search

MarioniLab / DropletUtils

Clone of the Bioconductor repository for the DropletUtils package.
https://bioconductor.org/packages/devel/bioc/html/DropletUtils.html
56 stars 27 forks source link

riscv64 test Failure ('test-hashing.R:244:9'): edge cases are handled correctly with combinatorial barcodes #113

Closed mr-c closed 1 month ago

mr-c commented 1 month ago

Hello,

In Debian, we have a single test failing on riscv64

── Failure ('test-hashing.R:244:9'): edge cases are handled correctly with combinatorial barcodes ──
 out$LogFC not identical to .compute_expected_lfc(SCALING, PSEUDO).
 Objects equal but not identical

We could patch the test to use expect_equal instead of expect_identical, but I wanted to check here first to see if that was okay

LTLA commented 1 month ago

Yeah, we should probably change it to expect_equal(). I don't think floating-point identity is a requirement of that particular test.

mr-c commented 1 month ago

@LTLA Thanks, we'll do that.

jonathangriffiths commented 1 month ago

Thanks both for the work on this!