MarioniLab / scran

Clone of the Bioconductor repository for the scran package.
https://bioconductor.org/packages/devel/bioc/html/scran.html
39 stars 23 forks source link

Different list for findmarker function #100

Open angkoomin opened 2 years ago

angkoomin commented 2 years ago

Hi there,

I'm trying to do a DEG between groups. I applied these two codes:

Code 1: marker.genes.cluster <- findMarkers(cdScFiltAnnot_Luminal, groups = cdScFiltAnnot_Luminal$Tissue_Zone, pval.type = "all", BPPARAM = bpp)

Code 2: marker.genes.cluster.up <- findMarkers(cdScFiltAnnot_Luminal, groups = cdScFiltAnnot_Luminal$Tissue_Zone, pval.type = "all", lfc = 0.5, direction = "up", BPPARAM = bpp)

I'm getting a very different list of upregulated genes for both as below. This is the gene list in descending order of LFC for code 1:

image

And code 2:

image

I was wondering if someone can help to explain why I'm getting 2 very different list as I thought the 'direction' and 'lfc' is to help to filter rather than give a very different list. Please help as it will determine which code to use for further downstream analysis.

Thanks

PeteHaitch commented 2 years ago

It looks like the function is doing exactly what you're telling it to do. With your second function call, you're saying "prioritise genes that have a logFC > 0.5 (lfc = 0.5 and direction = "up") in all pairwise comparisons (pval.type = "all"). There aren't many genes that satisfy those conditions. But eyeballing the first list, those genes include: ZFP36, CEBPD, DUSP1, NR4A1, CYP1B1, ZFP36L2, KLF6, ..., which are exactly the top hits in the second list.