MarioniLab / scran

Clone of the Bioconductor repository for the scran package.
https://bioconductor.org/packages/devel/bioc/html/scran.html
39 stars 23 forks source link

fix error unused argument objective_function when pass both block and graph.fun #109

Closed Yunuuuu closed 5 days ago

Yunuuuu commented 1 year ago

When pass block and graph.fun function, the graph.fun won't be passed bo the nested .quick_cluster function

scran::quickCluster(
        sce_object,
        d = 50L,
        graph.fun = "leiden",
        k = 15L, type = "jaccard",
        cluster.args = list(
            objective_function = "modularity",
            resolution_parameter = 0.8,
            n_iterations = -1L # undocumented characteristics
        ),
        block = sce_object$title,
        BSPARAM = BiocSingular::IrlbaParam()
)

image

LTLA commented 5 days ago

Oops, sorry for the late reply, just noticed this. Thanks for the PR.