search

MarioniLab / scran

Clone of the Bioconductor repository for the scran package.
https://bioconductor.org/packages/devel/bioc/html/scran.html
40 stars 22 forks source link

Add option for tricube doublet kernel #51

Closed jonathangriffiths closed 4 years ago

jonathangriffiths commented 4 years ago

I've restored the option to use the tricube kernel here, as well as making a small change to the documentation that covers (what I think is) the newer approach.

I've not been able to test this, as I don't have a suitable R environment installed, and I'm not inclined to make one! However, the changes are small, and default behaviour really ought to be unaffected. I'm hoping it might be easy on your end to give it a whirl?

I'm not sure if you'll be happy with ending the function with a big if/else block - let me know if there is a more elegant solution, short of pulling out the blocks into a separate function.

LTLA commented 4 years ago

Need evidence for why this is necessary.

Also self.dist is a KNN result while sim.dist is a range result.

jonathangriffiths commented 4 years ago

Good spot.

Evidence won't be forthcoming right away, but I will try to put something together soon.

jonathangriffiths commented 4 years ago

Closing for now, need to test more before this should be implemented