MarioniLab / scran

Clone of the Bioconductor repository for the scran package.
https://bioconductor.org/packages/devel/bioc/html/scran.html
39 stars 23 forks source link

Fall back to combining pure one-sided tests for direction=any. #88

Closed LTLA closed 3 years ago

LTLA commented 3 years ago

From discussion in #86.

This is unnecessarily conservative in the special case of direction="any", lfc >> 0 and block=NULL. But I don't want to handle that special case, and I can't figure out how to generalize the less-conservative approach to survive Stouffer's method.

In some respects, the conservativeness of the special case doesn't really matter, given how low the p-values are anyway.