Mariovc / ImagePicker

Android library to easily pick an image from gallery or camera app. The users can select their prefered gallery/camera app on a unique Intent. Initial gist:
https://gist.github.com/Mariovc/f06e70ebe8ca52fbbbe2
Apache License 2.0
158 stars 52 forks source link

Making camera intent available for apps without camera permission in manifest. #11

Closed tdekoning closed 7 years ago

tdekoning commented 7 years ago

I had a little bit of free time so i decided to test something regarding my last pull request and it appears to have an issue...

The issue was that if you would have an app without the CAMERA permission in the android manifest, the camera intent would not be shown by the imagepicker. This pull request makes sure that it will only check for camera permission when the androidmanifest.xml of the app contains the CAMERA permission.

To reproduce the faulty behaviour, just start up the demo app in this repo and see that the camera icon is not showing up.

My apologies for the bug

Mariovc commented 7 years ago

Well done. Thanks!