MarisElsins / getMOSPatch

getMOSPatch V2 - Tool that helps downloading patches from My Oracle Support
58 stars 17 forks source link

Generic Patches #16

Closed Pafke01 closed 4 years ago

Pafke01 commented 4 years ago

Generic patches are causing a litle issue. Example: 30170398 WEBLOGIC SAMPLES SPU 12.2.1.3.191015

config: 226P;Linux x86-64 233P;Microsoft Windows x64 (64-bit) 209P;IBM: Linux on System z 2000P;Generic Platform

It wil download to above patch 4 times.

Only 2000P;Generic Platform will download 1 time.

Regards,

Pafke

MarisElsins commented 4 years ago

Hi,

thanks for reporting this issue.

Could you post the whole log of how you initiate getMOSPatch and what's printed to the screen, please?

Maris

MarisElsins commented 4 years ago

OK, I understand the issue now.

The problem is that if you query for patches for a specific platform then the Generic patches are automatically included in the search results returned by Oracle. That's why you get the same patch 4 times. I think I will not try to solve this issue because it requires me to make some assumptions on what the search results will be, and I don't want to do that to avoid other potential issues in the future.

The only possible way to try to address this is to check if the file that's about to be downloaded is already present and of the same size. If it is - then I could skip the downloading.

I'll consider that for the future.