Smith morework - Atom Implementation Continued - Githubissues

Marist-CMPT331-TOPL / adder

Adder is a small but usable subset of the Python language. It is named for the Blackadder comedy series, much as the Python language is named for Monty Python.

MIT License

0 stars 2 forks source link

Smith morework - Atom Implementation Continued #71

Closed Stubeans closed 1 year ago

Stubeans commented 1 year ago

About to push changes...

Stubeans commented 1 year ago

So I moved the valueOfBop above where it's being called, and added a case. However, I realize that the case may be accidentally recursive. Do I have the right idea?

I also consolidated the valueOf statement, and moved the valueOf( BinaryExpr...)... above the undefined case.

Stubeans commented 1 year ago

I fixed a build issue but I'm not sure If i did it correctly. I'm really not sure at all about what valueOfBop does exactly, I assumed I had to call BinaryExpr somehow to reach that code.

And don't I have to store both values? Val1 and Val2?

Stubeans commented 1 year ago

And I believe I got the try in the right place for the literals fix

Stubeans commented 1 year ago

Should be all good now. I was able to build and run.