Feature/blog-authors - Githubissues

Maritime-Robotics-Student-Society / blog

Southampton sailing robot blog site

https://blog.sotonsailrobot.org/

MIT License

1 stars 1 forks source link

Feature/blog-authors #13

Closed zysim closed 6 years ago

zysim commented 6 years ago

This branch is to solve #12. Stuff I've done include:

Every blog post made so far should print out the author at the bottom now
data.authors created in _config.yml which enables my previous bullet point, plus extra info
Author's avatar will be replaced by the first letter of their name if we don't have an image

takluyver commented 6 years ago

This sounds OK to me - I assume you've tested building it and it works as described.

If you've got time to investigate, maybe you could try to fix the netlify builds - it looks like they're running jekyll serve when they should be running jekyll build. I've no idea where that's controlled from, though.

zysim commented 6 years ago

Aye I'll look into the netlify build when I can. @Nanoseb Ok for me to merge?

Nanoseb commented 6 years ago

Arg, really sorry for the delay, I saw it but then forgot about it... Concerning the bio ;) how visible is the text? is it on every blog post? if so maybe leave it empty for now, and every one can add its own.

zysim commented 6 years ago

Updating this PR with a merge from gh-pages, and a new commit, ba148b. This new commit allows an optional, article-specific author bio, christened author_bio that is placed in the front matter for every article. If it is set, it will be displayed in the bio at the bottom of the article page. This is also meant to default to the bios set in _config.yml, but the code for that is currently commented out, until we create decent default bios for everyone. Hence, if author_bio isn't set, it'll just display the author's name and nothing else.