search

MaritzSTL / chameleon

Chameleon Web Components - A collection of lightweight, unidirectional, framework-agnostic elements based on the Chameleon Design System
https://chameleon-design-system.netlify.app
MIT License
27 stars 7 forks source link

Hash Tabs Enhancement #344

Closed ryuhhnn closed 4 years ago

ryuhhnn commented 4 years ago

This will allow users to set an ID on the <chameleon-tabs> element and set the selected index using query parameters like so: http://localhost/somepage?tabs_someid=1

ryuhhnn commented 4 years ago

Approved. We should also add the reverse functionality and update the url when the user changes tabs. It'd also be useful to accept ids for individual tab names.

Doh, I knew I was forgetting something! Will make a follow up PR, thanks for reminding me @kewalter

ryuhhnn commented 4 years ago
  • Would be good to follow up on what Keith was talking about

PR incomming!

  • Don't see tests for this

Test runner is broken right now so I was holding off on tests, but will follow up on this.

  • What do you think about (maybe in a major version bump, with backwards compatibility for a time) moving from chameleon.-prefixed events to more browser canonical? (just a suggestion - probably needs some more thought)

I'm fine with that! Can you open up an RFC issue for that to discuss @ZempTime ? We just recently decided to move over to the chameleon.-prefixed events, so want to make sure there's good justification and understanding before going and switching it again