MariusM95 / android-rcs-ims-stack

Automatically exported from code.google.com/p/android-rcs-ims-stack
0 stars 0 forks source link

The new display name parameter is being passed on the wrong position on some RichMessaging's functions #190

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I think the new v2.5.14 update has a problem on some functions of the 
RichMessaging class:
 - public void addIncomingGeoloc(GeolocMessage geoloc) {
 - public void addOutgoingGeoloc(GeolocMessage geoloc) {
 - public void addSpamMessage(InstantMessage msg) {
 - public void addIncomingChatMessage(InstantMessage msg, String chatId) {

When calling "addEntry", the display name position should be in the sixth 
position, but on those functions in not on that position, e.g., on 
"addIncomingGeoloc" is in the ninth position. This is shifting/switching some 
fields on the DB.

  BAD:
    addEntry(type, null, null, geoloc.getMessageId(), geoloc.getRemote(), geolocData, GeolocMessage.MIME_TYPE, geoloc.getRemote(),
             >> geoloc.getDisplayName() <<, geolocData.length(), geoloc.getDate(), status);
  OK:
    addEntry(type, null, null, geoloc.getMessageId(), geoloc.getRemote(), >> geoloc.getDisplayName() <<, geolocData, GeolocMessage.MIME_TYPE,
             geoloc.getRemote(), geolocData.length(), geoloc.getDate(), status);

Original issue reported on code.google.com by RCSe...@googlemail.com on 19 Dec 2013 at 1:41

GoogleCodeExporter commented 9 years ago
Fixed on trunk

Original comment by lemordan...@gmail.com on 20 Dec 2013 at 8:50