search

MariusRumpf / node-lifx

Node.js implementation of the LIFX LAN protocol :bulb:
MIT License
144 stars 28 forks source link

Fix socket.bind() for nodejs 0.10 part compatibility #17

Closed Nibbler999 closed 9 years ago

Nibbler999 commented 9 years ago

socket.bind(options) doesn't exist in node 0.10

MariusRumpf commented 9 years ago

I won't add support for node v0.10 or support it some time in the future. Since there is no interference with the current use and this makes it useable somewhat I will merge it anyway. Thanks for your work.

Note: There are still two test not passing with node v0.10 (one for package headers), so this library might still not work as expected there.

Nibbler999 commented 9 years ago

I took a look at these tests. The first failure is caused by the test itself and can be ignored. The second looks like something that should be fixed anyway - passing undefined to writeUInt8().

MariusRumpf commented 9 years ago

Just checked it and both tests are failing by a test itself, node v0.10 seems to work for now.