search

MariusRumpf / node-lifx

Node.js implementation of the LIFX LAN protocol :bulb:
MIT License
144 stars 28 forks source link

Implement infrared color packets to control LIFX+ #40

Closed MariusRumpf closed 7 years ago

MariusRumpf commented 8 years ago

The new LIFX+ lamp does use a different message to set it's "color" since it uses infrared light. These message have to be implemented to control these. Documentation can be found here.

ristomatti commented 8 years ago

@MariusRumpf I would like try to help with this and also #41. I have pre-ordered both LIFX Z and LIFX+ but my experience with protocol level communication is limited and I would probably need some support or pointers along the way.

My only experience is from last week, trying to understand the inner workings of node-lifx to improve its performance when sending commands to multiple lights. With trial, error and luck I found two distinct ways to do that. I'm planning on creating separate pull requests on these (it might take a while before I find time to do that though). In case I get that far - would the pull requests be sufficient or should I also create issues to link them to?

MariusRumpf commented 8 years ago

Yeah, feel free to do so and add pull requests then, no separate issues needed. Maybe I should add a gitter chat so you we can talk when needed.

ristomatti commented 8 years ago

That would be really helpful especially when I get the new devices and need to try and make sense of the protocol specification. But I also have some questions about architectural decisions related to the performance improvements. Would it be ok to contact you through email?

MariusRumpf commented 8 years ago

https://gitter.im/node-lifx/Lobby

MariusRumpf commented 7 years ago

Thanks for all the work, this is now part of the 0.8.0 release.