add feature flags to LIFX_PRODUCT_IDS

MariusRumpf / node-lifx

Node.js implementation of the LIFX LAN protocol :bulb:

MIT License

144 stars 28 forks source link

add feature flags to LIFX_PRODUCT_IDS #46

Closed devbobo closed 7 years ago

devbobo commented 8 years ago

Add feature flags to prevent having to parse the product name to determine what features a bulb supports.

codecov-io commented 8 years ago

Current coverage is 60.02% (diff: 100%)

Merging #46 into master will not change coverage

@@             master        #46   diff @@
==========================================
  Files            42         42          
  Lines          1346       1346          
  Methods         111        111          
  Messages          0          0          
  Branches        216        216          
==========================================
  Hits            808        808          
  Misses          538        538          
  Partials          0          0

Powered by Codecov. Last update 4760094...d6faf2c

MariusRumpf commented 7 years ago

Thanks for your work. I decided to go a bit of a different way. Since db931173bc519c1b54fd4572fc49a1a7ceb4fda4 I use the official json file now which also lists the features. This makes it easier to update it in pull requests too.