Open ristomatti opened 7 years ago
Merging #61 into es2015 will increase coverage by
0.72%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## es2015 #61 +/- ##
==========================================
+ Coverage 58.41% 59.13% +0.72%
==========================================
Files 50 50
Lines 1688 1713 +25
Branches 255 259 +4
==========================================
+ Hits 986 1013 +27
+ Misses 702 700 -2
Impacted Files | Coverage Δ | |
---|---|---|
lib/lifx/client.js | 90.66% <0%> (+1.57%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0468de6...62a4052. Read the comment docs.
I've used a prototype version of this implementation for quite some time to avoid lights dropping out occasionally in my node-red home automation setup.
If for example below settings are passed to client on init, the discovery process will stop after the listed lights have been discovered. This prevents discovery processing setting lights offline if they don't respond for some reason. I've found this does not necessarily prevent packets being processed on the lights.
Client will emit
discovery-completed
after the lights are found if the configuration option is enabled.This PR is done against the base branch es2015 like my earlier PR #60 from today.